Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Side by Side Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

Issue 2098243002: Remove unnecessary finalization of IDBObserver classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/indexeddb/IDBObserver.h" 5 #include "modules/indexeddb/IDBObserver.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/modules/v8/ToV8ForModules.h" 8 #include "bindings/modules/v8/ToV8ForModules.h"
9 #include "bindings/modules/v8/V8BindingForModules.h" 9 #include "bindings/modules/v8/V8BindingForModules.h"
10 #include "modules/indexeddb/IDBObserverCallback.h" 10 #include "modules/indexeddb/IDBObserverCallback.h"
11 #include "modules/indexeddb/IDBObserverInit.h" 11 #include "modules/indexeddb/IDBObserverInit.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 IDBObserver* IDBObserver::create(IDBObserverCallback& callback, const IDBObserve rInit& options) 15 IDBObserver* IDBObserver::create(IDBObserverCallback& callback, const IDBObserve rInit& options)
16 { 16 {
17 return new IDBObserver(callback, options); 17 return new IDBObserver(callback, options);
18 } 18 }
19 19
20 IDBObserver::IDBObserver(IDBObserverCallback& callback, const IDBObserverInit& o ptions) 20 IDBObserver::IDBObserver(IDBObserverCallback& callback, const IDBObserverInit& o ptions)
21 : m_callback(&callback) 21 : m_callback(&callback)
22 , m_transaction(options.transaction()) 22 , m_transaction(options.transaction())
23 , m_values(options.values()) 23 , m_values(options.values())
24 , m_noRecords(options.noRecords()) 24 , m_noRecords(options.noRecords())
25 { 25 {
26 } 26 }
27 27
28 IDBObserver::~IDBObserver() {}
29
30 void IDBObserver::observe(IDBDatabase* database, IDBTransaction* transaction, Ex ceptionState& exceptionState) 28 void IDBObserver::observe(IDBDatabase* database, IDBTransaction* transaction, Ex ceptionState& exceptionState)
31 { 29 {
32 // TODO(palakj): Finish implementation. 30 // TODO(palakj): Finish implementation.
33 } 31 }
34 32
35 DEFINE_TRACE(IDBObserver) 33 DEFINE_TRACE(IDBObserver)
36 { 34 {
37 visitor->trace(m_callback); 35 visitor->trace(m_callback);
38 } 36 }
39 37
40 } // namespace blink 38 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698