Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 209823002: Remove cookieRequestHeaderFieldValue() and setCookie() call from WebSocketHandshake (Closed)

Created:
6 years, 9 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 8 months ago
Reviewers:
yhirano
CC:
blink-reviews, jamesr, dglazkov+blink, Nate Chapin, gavinp+loader_chromium.org, abarth-chromium
Visibility:
Public.

Description

Remove cookieRequestHeaderFieldValue() and setCookie() call from WebSocketHandshake These calls were for non-Chromium port of WebKit to get/set cookies on WebSocket opening handshake. In Blink, they're no longer necessary. Chromium intercepts handshakes in the browser process and add/remove cookies. Any cookie header added by Blink is ignored. Set-cookies are stripped before forwarded to Blink. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170560

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : Addressed #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -27 lines) Patch
M Source/modules/websockets/MainThreadWebSocketChannel.cpp View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M Source/modules/websockets/WebSocketHandshake.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocketHandshake.cpp View 1 2 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 9 months ago (2014-03-24 09:26:10 UTC) #1
yhirano
https://codereview.chromium.org/209823002/diff/20001/Source/modules/websockets/MainThreadWebSocketChannel.cpp File Source/modules/websockets/MainThreadWebSocketChannel.cpp (left): https://codereview.chromium.org/209823002/diff/20001/Source/modules/websockets/MainThreadWebSocketChannel.cpp#oldcode41 Source/modules/websockets/MainThreadWebSocketChannel.cpp:41: #include "core/loader/CookieJar.h" Is it necessary? https://codereview.chromium.org/209823002/diff/20001/Source/modules/websockets/WebSocketHandshake.cpp File Source/modules/websockets/WebSocketHandshake.cpp (right): ...
6 years, 9 months ago (2014-03-26 07:08:32 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/209823002/diff/20001/Source/modules/websockets/MainThreadWebSocketChannel.cpp File Source/modules/websockets/MainThreadWebSocketChannel.cpp (left): https://codereview.chromium.org/209823002/diff/20001/Source/modules/websockets/MainThreadWebSocketChannel.cpp#oldcode41 Source/modules/websockets/MainThreadWebSocketChannel.cpp:41: #include "core/loader/CookieJar.h" On 2014/03/26 07:08:32, yhirano wrote: > Is ...
6 years, 8 months ago (2014-04-01 11:11:22 UTC) #3
yhirano
lgtm
6 years, 8 months ago (2014-04-01 11:21:16 UTC) #4
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 8 months ago (2014-04-01 11:59:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/209823002/60001
6 years, 8 months ago (2014-04-01 11:59:48 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 13:13:06 UTC) #7
Message was sent while issue was closed.
Change committed as 170560

Powered by Google App Engine
This is Rietveld 408576698