Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: Source/modules/websockets/WebSocketHandshake.h

Issue 209823002: Remove cookieRequestHeaderFieldValue() and setCookie() call from WebSocketHandshake (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed #2 Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/websockets/WebSocketHandshake.h
diff --git a/Source/modules/websockets/WebSocketHandshake.h b/Source/modules/websockets/WebSocketHandshake.h
index f1a3e95b87051dbf776a12dbf1d2530ec1289735..2053bba87fb0a06a1c04aae1ff48c4f23d8c5b18 100644
--- a/Source/modules/websockets/WebSocketHandshake.h
+++ b/Source/modules/websockets/WebSocketHandshake.h
@@ -67,7 +67,12 @@ public:
String clientOrigin() const;
String clientLocation() const;
+ // Builds a WebSocket opening handshake string to send to the server.
+ // Cookie headers will be added later by the platform code for security
+ // reason.
CString clientHandshakeMessage() const;
+ // Builds an object representing WebSocket opening handshake to pass to the
+ // inspector.
PassRefPtr<WebSocketHandshakeRequest> clientHandshakeRequest() const;
// We're collecting data for histogram in the destructor. Note that calling
@@ -81,8 +86,6 @@ public:
String failureReason() const;
const AtomicString& serverWebSocketProtocol() const;
- const AtomicString& serverSetCookie() const;
- const AtomicString& serverSetCookie2() const;
const AtomicString& serverUpgrade() const;
const AtomicString& serverConnection() const;
const AtomicString& serverWebSocketAccept() const;
« no previous file with comments | « Source/modules/websockets/MainThreadWebSocketChannel.cpp ('k') | Source/modules/websockets/WebSocketHandshake.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698