Convert video-src-[plus-source, remove, set, source].html tests to testharness.js

Convert video-src-[plus-source, remove, set, source].html tests to testharness.js

Cleaning up video-src-[plus-source, remove, set, source].html tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/464ce984180cbf5a482c1287d3123ca74e03ef34
Cr-Commit-Position: refs/heads/master@{#402082}

[Srirama, 2016-06-26 05:53:43]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert video-src-[plus-source, remove, set, source].html tests to
testharness.js

Cleaning up video-src-[plus-source, remove, set, source].html tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-06-26 06:04:10]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-06-26 06:04:11]

PTAL

[fs, 2016-06-26 15:10:44]

LGTM w/ nits

https://codereview.chromium.org/2098213002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-src-remove.html (right):

https://codereview.chromium.org/2098213002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-remove.html:19:
video.onloadedmetadata = t.unreached_func();
Because of this we should never "re-enter" this function, right? So maybe just
assert loadCount === 1 and drop the if?

https://codereview.chromium.org/2098213002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-src-source.html (right):

https://codereview.chromium.org/2098213002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-source.html:14: video.onloadstart
= t.step_func_done(function () {
Nit: space before ()

[Srirama, 2016-06-26 18:14:03]

https://codereview.chromium.org/2098213002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-src-remove.html (right):

https://codereview.chromium.org/2098213002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-remove.html:19:
video.onloadedmetadata = t.unreached_func();
On 2016/06/26 15:10:43, fs wrote:
> Because of this we should never "re-enter" this function, right? So maybe just
> assert loadCount === 1 and drop the if? 

I think the loadCount check doesn't make sense as it is always 1, so removed it.

https://codereview.chromium.org/2098213002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-src-source.html (right):

https://codereview.chromium.org/2098213002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-src-source.html:14: video.onloadstart
= t.step_func_done(function () {
On 2016/06/26 15:10:43, fs wrote:
> Nit: space before ()

Done.

[Srirama, 2016-06-26 18:14:16]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-06-26 18:14:18]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2098213002/#ps20001
(title: "address nits")

[commit-bot: I haz the power, 2016-06-26 18:14:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-26 19:23:09]

Description was changed from

==========
Convert video-src-[plus-source, remove, set, source].html tests to
testharness.js

Cleaning up video-src-[plus-source, remove, set, source].html tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-src-[plus-source, remove, set, source].html tests to
testharness.js

Cleaning up video-src-[plus-source, remove, set, source].html tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-06-26 19:23:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-26 19:25:09]

Description was changed from

==========
Convert video-src-[plus-source, remove, set, source].html tests to
testharness.js

Cleaning up video-src-[plus-source, remove, set, source].html tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-src-[plus-source, remove, set, source].html tests to
testharness.js

Cleaning up video-src-[plus-source, remove, set, source].html tests
in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/464ce984180cbf5a482c1287d3123ca74e03ef34
Cr-Commit-Position: refs/heads/master@{#402082}
==========

[commit-bot: I haz the power, 2016-06-26 19:25:10]

Patchset 2 (id:??) landed as
https://crrev.com/464ce984180cbf5a482c1287d3123ca74e03ef34
Cr-Commit-Position: refs/heads/master@{#402082}