third_party/WebKit/LayoutTests/media/video-src-source.html - Issue 2098213002: Convert video-src-[plus-source, remove, set, source].html tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-src-source.html

Issue 2098213002: Convert video-src-[plus-source, remove, set, source].html tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/video-src-remove.html ('K') | « third_party/WebKit/LayoutTests/media/video-src-set-expected.txt ('k') | third_party/WebKit/LayoutTests/media/video-src-source-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <body>	1 <!DOCTYPE html>

2 <video><source></source></video>	2 <title>Test that a "source" element is not used when "src" attribute is set.</ti tle>

3 <script src=media-file.js></script>	3 <script src="../resources/testharness.js"></script>

4 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956	4 <script src="../resources/testharnessreport.js"></script>

5 (Please avoid writing new tests using video-test.js) -->	5 <script src="media-file.js"></script>

6 <script src=video-test.js></script>	6 <video>

	7 <source></source>

	8 </video>

7 <script>	9 <script>

	10 async_test(function(t) {

	11 var video = document.querySelector("video");

8 var mediaFile = findMediaFile("video", "content/test");	12 var mediaFile = findMediaFile("video", "content/test");

9 waitForEvent('loadstart', function () {	13

10 testExpected("stripExtension(relativeURL(video.currentSrc))", stripExten sion(mediaFile));	14 video.onloadstart = t.step_func_done(function () {
	fs 2016/06/26 15:10:43 Nit: space before () Nit: space before () Srirama 2016/06/26 18:14:03 Done. Show quoted text On 2016/06/26 15:10:43, fs wrote: > Nit: space before () Done.
11 endTest();	15 var url = video.currentSrc;

12 } );	16 assert_equals(url.substr(url.lastIndexOf("/media/")+7), mediaFile);

13 document.getElementsByTagName('source')[0].src = "content/error.mpeg";	17 });

14 mediaElement.src = mediaFile;	18

15 </script>	19 document.querySelector("source").src = "content/error.mpeg";

	20 video.src = mediaFile;

	21 });

	22 </script>

OLD	NEW