Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2098043002: Options: add a "Learn more" link to Android Apps section and tweak strings (Closed)

Created:
4 years, 6 months ago by Dan Beam
Modified:
4 years, 6 months ago
Reviewers:
Ben Kwa
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Options: add a "Learn more" link to Android Apps section and tweak strings R=kenobi@chromium.org BUG=623232 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/954c805472b539d39f1ef484999e03178613d547 Cr-Commit-Position: refs/heads/master@{#402018}

Patch Set 1 #

Total comments: 2

Patch Set 2 : kenobi@ string tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Dan Beam
https://codereview.chromium.org/2098043002/diff/1/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/2098043002/diff/1/chrome/browser/resources/options/browser_options.html#newcode374 chrome/browser/resources/options/browser_options.html:374: i18n-values="href:privacyLearnMoreURL"></a> I just pasted the URL directly into the ...
4 years, 6 months ago (2016-06-24 22:30:17 UTC) #2
Ben Kwa
lgtm
4 years, 6 months ago (2016-06-24 22:32:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098043002/20001
4 years, 6 months ago (2016-06-24 23:03:12 UTC) #7
Ben Kwa
still lgtm
4 years, 6 months ago (2016-06-24 23:09:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-24 23:49:07 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 23:50:53 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/954c805472b539d39f1ef484999e03178613d547
Cr-Commit-Position: refs/heads/master@{#402018}

Powered by Google App Engine
This is Rietveld 408576698