Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: chrome/browser/resources/options/browser_options.html

Issue 2098043002: Options: add a "Learn more" link to Android Apps section and tweak strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <div id="settings" class="page" hidden> 1 <div id="settings" class="page" hidden>
2 <header> 2 <header>
3 <h1 i18n-content="settingsTitle"></h1> 3 <h1 i18n-content="settingsTitle"></h1>
4 </header> 4 </header>
5 <include src="automatic_settings_reset_banner.html"> 5 <include src="automatic_settings_reset_banner.html">
6 <if expr="chromeos"> 6 <if expr="chromeos">
7 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_ico n.html"> 7 <link rel="import" href="chrome://resources/cr_elements/network/cr_network_ico n.html">
8 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.h tml"> 8 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.h tml">
9 <include src="secondary_user_banner.html"> 9 <include src="secondary_user_banner.html">
10 <section id="network-section-cros"> 10 <section id="network-section-cros">
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 <div class="checkbox controlled-setting-with-label"> 230 <div class="checkbox controlled-setting-with-label">
231 <label> 231 <label>
232 <input id="android-apps-enabled" pref="arc.enabled" 232 <input id="android-apps-enabled" pref="arc.enabled"
233 metric="Options_AndroidApps" type="checkbox" dialog-pref> 233 metric="Options_AndroidApps" type="checkbox" dialog-pref>
234 <span> 234 <span>
235 <span i18n-content="androidAppsEnabled"></span> 235 <span i18n-content="androidAppsEnabled"></span>
236 <span class="controlled-setting-indicator" 236 <span class="controlled-setting-indicator"
237 pref="arc.enabled"></span> 237 pref="arc.enabled"></span>
238 </span> 238 </span>
239 </label> 239 </label>
240 <a target="_blank" i18n-content="learnMore"
241 href="http://support.google.com/chromebook?p=playapps"></a>
240 </div> 242 </div>
241 <div id="android-apps-settings" class="controlled-setting-with-label" hidden > 243 <div id="android-apps-settings" class="controlled-setting-with-label" hidden >
242 <label> 244 <label>
243 <span id="android-apps-settings-label"></span> 245 <span id="android-apps-settings-label"></span>
244 </label> 246 </label>
245 </div> 247 </div>
246 </section> 248 </section>
247 </if> 249 </if>
248 <section id="sync-users-section" guest-visibility="hidden"> 250 <section id="sync-users-section" guest-visibility="hidden">
249 <h3 i18n-content="sectionTitleUsers"></h3> 251 <h3 i18n-content="sectionTitleUsers"></h3>
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 <div class="settings-row"> 364 <div class="settings-row">
363 <button id="privacyContentSettingsButton" 365 <button id="privacyContentSettingsButton"
364 i18n-content="privacyContentSettingsButton"></button> 366 i18n-content="privacyContentSettingsButton"></button>
365 <button id="privacyClearDataButton" 367 <button id="privacyClearDataButton"
366 i18n-content="privacyClearDataButton"></button> 368 i18n-content="privacyClearDataButton"></button>
367 </div> 369 </div>
368 <p id="privacy-explanation" class="settings-row"> 370 <p id="privacy-explanation" class="settings-row">
369 <span i18n-content="improveBrowsingExperience"></span> 371 <span i18n-content="improveBrowsingExperience"></span>
370 <span i18n-content="disableWebServices"></span> 372 <span i18n-content="disableWebServices"></span>
371 <a target="_blank" i18n-content="learnMore" 373 <a target="_blank" i18n-content="learnMore"
372 i18n-values="href:privacyLearnMoreURL"></a> 374 i18n-values="href:privacyLearnMoreURL"></a>
Dan Beam 2016/06/24 22:30:17 I just pasted the URL directly into the HTML becau
373 </p> 375 </p>
374 <div class="checkbox controlled-setting-with-label"> 376 <div class="checkbox controlled-setting-with-label">
375 <label> 377 <label>
376 <input id="alternateErrorPagesEnabled" 378 <input id="alternateErrorPagesEnabled"
377 pref="alternate_error_pages.enabled" 379 pref="alternate_error_pages.enabled"
378 metric="Options_LinkDoctorCheckbox" type="checkbox"> 380 metric="Options_LinkDoctorCheckbox" type="checkbox">
379 <span> 381 <span>
380 <span i18n-content="linkDoctorPref"></span> 382 <span i18n-content="linkDoctorPref"></span>
381 <span class="controlled-setting-indicator" 383 <span class="controlled-setting-indicator"
382 pref="alternate_error_pages.enabled"></span> 384 pref="alternate_error_pages.enabled"></span>
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
800 </if> 802 </if>
801 803
802 <if expr="chromeos"> 804 <if expr="chromeos">
803 <include src="startup_section.html"> 805 <include src="startup_section.html">
804 </if> 806 </if>
805 807
806 <section id="a11y-section"> 808 <section id="a11y-section">
807 <h3 i18n-content="accessibilityTitle"></h3> 809 <h3 i18n-content="accessibilityTitle"></h3>
808 810
809 <div> 811 <div>
810 <a href="https://chrome.google.com/webstore/category/collection/accessibilit y" 812 <a href="https://chrome.google.com/webstore/category/collection/accessibilit y"
Dan Beam 2016/06/24 22:30:17 ^ just like this one
811 id="accessibility-features" target="_blank" 813 id="accessibility-features" target="_blank"
812 i18n-content="accessibilityFeaturesLink"></a> 814 i18n-content="accessibilityFeaturesLink"></a>
813 </div> 815 </div>
814 816
815 <if expr="chromeos"> 817 <if expr="chromeos">
816 <div class="option-control-table"> 818 <div class="option-control-table">
817 <p id="accessibility-explanation" class="settings-row"> 819 <p id="accessibility-explanation" class="settings-row">
818 <span i18n-content="accessibilityExplanation"></span> 820 <span i18n-content="accessibilityExplanation"></span>
819 <a id="accessibility-learn-more" target="_blank" 821 <a id="accessibility-learn-more" target="_blank"
820 i18n-values="href:accessibilityLearnMoreURL" 822 i18n-values="href:accessibilityLearnMoreURL"
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
1120 </button> 1122 </button>
1121 </div> 1123 </div>
1122 </section> 1124 </section>
1123 </div> <!-- advanced-settings-container --> 1125 </div> <!-- advanced-settings-container -->
1124 </div> <!-- advanced-settings --> 1126 </div> <!-- advanced-settings -->
1125 <footer id="advanced-settings-footer"> 1127 <footer id="advanced-settings-footer">
1126 <a is="action-link" id="advanced-settings-expander" 1128 <a is="action-link" id="advanced-settings-expander"
1127 i18n-content="showAdvancedSettings"></a> 1129 i18n-content="showAdvancedSettings"></a>
1128 </footer> 1130 </footer>
1129 </div> 1131 </div>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698