mash: Migrate remaining tray observers and notify functions.

mash: Migrate remaining tray observers and notify functions.

Move observers to common (but not their implementations):
tools/git/move_source_file.py ash/system/chromeos/bluetooth/bluetooth_observer.h ash/common/system/chromeos/bluetooth/
tools/git/move_source_file.py ash/system/chromeos/enterprise/enterprise_domain_observer.h ash/common/system/chromeos/enterprise/
tools/git/move_source_file.py ash/system/chromeos/network/network_observer.h ash/common/system/chromeos/network/
tools/git/move_source_file.py ash/system/chromeos/network/network_portal_detector_observer.h ash/common/system/chromeos/network/
tools/git/move_source_file.py ash/system/chromeos/screen_security/screen_capture_observer.h ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py ash/system/chromeos/screen_security/screen_share_observer.h ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py ash/system/chromeos/session/last_window_closed_observer.h ash/common/system/chromeos/session/
tools/git/move_source_file.py ash/system/chromeos/session/logout_button_observer.h ash/common/system/chromeos/session/
tools/git/move_source_file.py ash/system/chromeos/session/session_length_limit_observer.h ash/common/system/chromeos/session/
tools/git/move_source_file.py ash/system/tray/media_security/media_capture_observer.h ash/common/system/chromeos/media_security/
tools/git/move_source_file.py ash/system/user/user_observer.h ash/common/system/user/

Move the ash/system/tray/media_security to ash/system/chromeos/:
tools/git/move_source_file.py ash/system/tray/media_security/* ash/system/chromeos/media_security/
(this fits the pattern of other cros system tray features)
Also remove the (now unnecessary) non-chromeos media_security build rules.

Merge and reorder remaining SystemTrayNotifier functions.
Rename WmSystemTrayNotifier to SystemTrayNotifier:
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.h ash/common/system/tray/system_tray_notifier.h
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.cc ash/common/system/tray/system_tray_notifier.cc

Use WmShell::Get()->GetSessionStateDelegate() more; minor cleanup and IWYU.
Use AshTestBase::GetPrimarySystemTray in screen_tray_item_unittest.cc

BUG=619636
TEST=Compiles; automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,yusukes@chromium.org,wez@chromium.org

Committed: https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2
Cr-Commit-Position: refs/heads/master@{#402022}

[msw, 2016-06-24 22:26:39]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 22:27:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 22:31:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 22:31:04]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msw, 2016-06-24 23:07:55]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[msw, 2016-06-24 23:08:09]

Patchset #5 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-06-24 23:08:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-06-24 23:17:01]

Description was changed from

==========
mash: Migrate remaining tray observers and notify functions.

BUG=619636
==========

to

==========
mash: Migrate remaining tray observers and notify functions.

Move observers to common (but not their implementations):
tools/git/move_source_file.py ash/system/chromeos/bluetooth/bluetooth_observer.h
ash/common/system/chromeos/bluetooth/
tools/git/move_source_file.py
ash/system/chromeos/enterprise/enterprise_domain_observer.h
ash/common/system/chromeos/enterprise/
tools/git/move_source_file.py ash/system/chromeos/network/network_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/network/network_portal_detector_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_capture_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_share_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/session/last_window_closed_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/logout_button_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/session_length_limit_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/tray/media_security/media_capture_observer.h
ash/common/system/chromeos/media_security/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/

Move the ash/system/tray/media_security to ash/system/chromeos/:
tools/git/move_source_file.py ash/system/tray/media_security/*
ash/system/chromeos/media_security/
(this fits the pattern of other cros system tray features)
Also remove the (now unnecessary) non-chromeos media_security build rules.

Merge and reorder remaining SystemTrayNotifier functions.
Rename WmSystemTrayNotifier to SystemTrayNotifier:
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.h
ash/common/system/tray/system_tray_notifier.h
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.cc
ash/common/system/tray/system_tray_notifier.cc

Use WmShell::Get()->GetSessionStateDelegate() more; minor cleanup and IWYU.
Use AshTestBase::GetPrimarySystemTray in screen_tray_item_unittest.cc

BUG=619636
TEST=Compiles; automated tests; no behavior changes.
R=jamescook@chromium.org
==========

[msw, 2016-06-24 23:17:01]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-06-24 23:18:05]

Hey James, please take a look; thanks!

[James Cook, 2016-06-24 23:37:04]

LGTM. Nice patch. It looks like it makes it possible for some things to just
move straight over.

https://codereview.chromium.org/2098023002/diff/100001/ash/shell.h
File ash/shell.h (left):

https://codereview.chromium.org/2098023002/diff/100001/ash/shell.h#oldcode645
ash/shell.h:645: std::unique_ptr<SystemTrayNotifier> system_tray_notifier_;
Hooray!

[msw, 2016-06-24 23:49:25]

Description was changed from

==========
mash: Migrate remaining tray observers and notify functions.

Move observers to common (but not their implementations):
tools/git/move_source_file.py ash/system/chromeos/bluetooth/bluetooth_observer.h
ash/common/system/chromeos/bluetooth/
tools/git/move_source_file.py
ash/system/chromeos/enterprise/enterprise_domain_observer.h
ash/common/system/chromeos/enterprise/
tools/git/move_source_file.py ash/system/chromeos/network/network_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/network/network_portal_detector_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_capture_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_share_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/session/last_window_closed_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/logout_button_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/session_length_limit_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/tray/media_security/media_capture_observer.h
ash/common/system/chromeos/media_security/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/

Move the ash/system/tray/media_security to ash/system/chromeos/:
tools/git/move_source_file.py ash/system/tray/media_security/*
ash/system/chromeos/media_security/
(this fits the pattern of other cros system tray features)
Also remove the (now unnecessary) non-chromeos media_security build rules.

Merge and reorder remaining SystemTrayNotifier functions.
Rename WmSystemTrayNotifier to SystemTrayNotifier:
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.h
ash/common/system/tray/system_tray_notifier.h
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.cc
ash/common/system/tray/system_tray_notifier.cc

Use WmShell::Get()->GetSessionStateDelegate() more; minor cleanup and IWYU.
Use AshTestBase::GetPrimarySystemTray in screen_tray_item_unittest.cc

BUG=619636
TEST=Compiles; automated tests; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate remaining tray observers and notify functions.

Move observers to common (but not their implementations):
tools/git/move_source_file.py ash/system/chromeos/bluetooth/bluetooth_observer.h
ash/common/system/chromeos/bluetooth/
tools/git/move_source_file.py
ash/system/chromeos/enterprise/enterprise_domain_observer.h
ash/common/system/chromeos/enterprise/
tools/git/move_source_file.py ash/system/chromeos/network/network_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/network/network_portal_detector_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_capture_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_share_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/session/last_window_closed_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/logout_button_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/session_length_limit_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/tray/media_security/media_capture_observer.h
ash/common/system/chromeos/media_security/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/

Move the ash/system/tray/media_security to ash/system/chromeos/:
tools/git/move_source_file.py ash/system/tray/media_security/*
ash/system/chromeos/media_security/
(this fits the pattern of other cros system tray features)
Also remove the (now unnecessary) non-chromeos media_security build rules.

Merge and reorder remaining SystemTrayNotifier functions.
Rename WmSystemTrayNotifier to SystemTrayNotifier:
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.h
ash/common/system/tray/system_tray_notifier.h
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.cc
ash/common/system/tray/system_tray_notifier.cc

Use WmShell::Get()->GetSessionStateDelegate() more; minor cleanup and IWYU.
Use AshTestBase::GetPrimarySystemTray in screen_tray_item_unittest.cc

BUG=619636
TEST=Compiles; automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,yusukes@chromium.org,wez@chromium.org
==========

[msw, 2016-06-24 23:49:25]

msw@chromium.org changed reviewers:
+ sky@chromium.org, wez@chromium.org, yusukes@chromium.org

[msw, 2016-06-24 23:51:23]

+TBR sky: chrome/*, yusukes: components/arc/*, wez: remoting/*

[Wez, 2016-06-24 23:55:32]

wez@chromium.org changed reviewers:
+ sergeyu@chromium.org
- wez@chromium.org

[Wez, 2016-06-24 23:55:33]

-wez, +sergeyu

[commit-bot: I haz the power, 2016-06-25 00:02:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-25 00:02:28]

Dry run: This issue passed the CQ dry run.

[msw, 2016-06-25 00:02:55]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-06-25 00:03:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-25 00:10:07]

Description was changed from

==========
mash: Migrate remaining tray observers and notify functions.

Move observers to common (but not their implementations):
tools/git/move_source_file.py ash/system/chromeos/bluetooth/bluetooth_observer.h
ash/common/system/chromeos/bluetooth/
tools/git/move_source_file.py
ash/system/chromeos/enterprise/enterprise_domain_observer.h
ash/common/system/chromeos/enterprise/
tools/git/move_source_file.py ash/system/chromeos/network/network_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/network/network_portal_detector_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_capture_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_share_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/session/last_window_closed_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/logout_button_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/session_length_limit_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/tray/media_security/media_capture_observer.h
ash/common/system/chromeos/media_security/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/

Move the ash/system/tray/media_security to ash/system/chromeos/:
tools/git/move_source_file.py ash/system/tray/media_security/*
ash/system/chromeos/media_security/
(this fits the pattern of other cros system tray features)
Also remove the (now unnecessary) non-chromeos media_security build rules.

Merge and reorder remaining SystemTrayNotifier functions.
Rename WmSystemTrayNotifier to SystemTrayNotifier:
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.h
ash/common/system/tray/system_tray_notifier.h
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.cc
ash/common/system/tray/system_tray_notifier.cc

Use WmShell::Get()->GetSessionStateDelegate() more; minor cleanup and IWYU.
Use AshTestBase::GetPrimarySystemTray in screen_tray_item_unittest.cc

BUG=619636
TEST=Compiles; automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,yusukes@chromium.org,wez@chromium.org
==========

to

==========
mash: Migrate remaining tray observers and notify functions.

Move observers to common (but not their implementations):
tools/git/move_source_file.py ash/system/chromeos/bluetooth/bluetooth_observer.h
ash/common/system/chromeos/bluetooth/
tools/git/move_source_file.py
ash/system/chromeos/enterprise/enterprise_domain_observer.h
ash/common/system/chromeos/enterprise/
tools/git/move_source_file.py ash/system/chromeos/network/network_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/network/network_portal_detector_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_capture_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_share_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/session/last_window_closed_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/logout_button_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/session_length_limit_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/tray/media_security/media_capture_observer.h
ash/common/system/chromeos/media_security/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/

Move the ash/system/tray/media_security to ash/system/chromeos/:
tools/git/move_source_file.py ash/system/tray/media_security/*
ash/system/chromeos/media_security/
(this fits the pattern of other cros system tray features)
Also remove the (now unnecessary) non-chromeos media_security build rules.

Merge and reorder remaining SystemTrayNotifier functions.
Rename WmSystemTrayNotifier to SystemTrayNotifier:
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.h
ash/common/system/tray/system_tray_notifier.h
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.cc
ash/common/system/tray/system_tray_notifier.cc

Use WmShell::Get()->GetSessionStateDelegate() more; minor cleanup and IWYU.
Use AshTestBase::GetPrimarySystemTray in screen_tray_item_unittest.cc

BUG=619636
TEST=Compiles; automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,yusukes@chromium.org,wez@chromium.org
==========

[commit-bot: I haz the power, 2016-06-25 00:10:09]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-06-25 00:13:25]

Description was changed from

==========
mash: Migrate remaining tray observers and notify functions.

Move observers to common (but not their implementations):
tools/git/move_source_file.py ash/system/chromeos/bluetooth/bluetooth_observer.h
ash/common/system/chromeos/bluetooth/
tools/git/move_source_file.py
ash/system/chromeos/enterprise/enterprise_domain_observer.h
ash/common/system/chromeos/enterprise/
tools/git/move_source_file.py ash/system/chromeos/network/network_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/network/network_portal_detector_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_capture_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_share_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/session/last_window_closed_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/logout_button_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/session_length_limit_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/tray/media_security/media_capture_observer.h
ash/common/system/chromeos/media_security/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/

Move the ash/system/tray/media_security to ash/system/chromeos/:
tools/git/move_source_file.py ash/system/tray/media_security/*
ash/system/chromeos/media_security/
(this fits the pattern of other cros system tray features)
Also remove the (now unnecessary) non-chromeos media_security build rules.

Merge and reorder remaining SystemTrayNotifier functions.
Rename WmSystemTrayNotifier to SystemTrayNotifier:
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.h
ash/common/system/tray/system_tray_notifier.h
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.cc
ash/common/system/tray/system_tray_notifier.cc

Use WmShell::Get()->GetSessionStateDelegate() more; minor cleanup and IWYU.
Use AshTestBase::GetPrimarySystemTray in screen_tray_item_unittest.cc

BUG=619636
TEST=Compiles; automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,yusukes@chromium.org,wez@chromium.org
==========

to

==========
mash: Migrate remaining tray observers and notify functions.

Move observers to common (but not their implementations):
tools/git/move_source_file.py ash/system/chromeos/bluetooth/bluetooth_observer.h
ash/common/system/chromeos/bluetooth/
tools/git/move_source_file.py
ash/system/chromeos/enterprise/enterprise_domain_observer.h
ash/common/system/chromeos/enterprise/
tools/git/move_source_file.py ash/system/chromeos/network/network_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/network/network_portal_detector_observer.h
ash/common/system/chromeos/network/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_capture_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/screen_security/screen_share_observer.h
ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py
ash/system/chromeos/session/last_window_closed_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/logout_button_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/chromeos/session/session_length_limit_observer.h
ash/common/system/chromeos/session/
tools/git/move_source_file.py
ash/system/tray/media_security/media_capture_observer.h
ash/common/system/chromeos/media_security/
tools/git/move_source_file.py ash/system/user/user_observer.h
ash/common/system/user/

Move the ash/system/tray/media_security to ash/system/chromeos/:
tools/git/move_source_file.py ash/system/tray/media_security/*
ash/system/chromeos/media_security/
(this fits the pattern of other cros system tray features)
Also remove the (now unnecessary) non-chromeos media_security build rules.

Merge and reorder remaining SystemTrayNotifier functions.
Rename WmSystemTrayNotifier to SystemTrayNotifier:
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.h
ash/common/system/tray/system_tray_notifier.h
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.cc
ash/common/system/tray/system_tray_notifier.cc

Use WmShell::Get()->GetSessionStateDelegate() more; minor cleanup and IWYU.
Use AshTestBase::GetPrimarySystemTray in screen_tray_item_unittest.cc

BUG=619636
TEST=Compiles; automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,yusukes@chromium.org,wez@chromium.org

Committed: https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2
Cr-Commit-Position: refs/heads/master@{#402022}
==========

[commit-bot: I haz the power, 2016-06-25 00:13:27]

Patchset 5 (id:??) landed as
https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2
Cr-Commit-Position: refs/heads/master@{#402022}