mash: Migrate remaining tray observers and notify functions.

ash/system/chromeos/screen_security/screen_tray_item_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/chromeos/screen_security/screen_tray_item.h"
 
+#include "ash/common/system/tray/system_tray_notifier.h"
 #include "ash/common/system/tray/tray_item_view.h"
-#include "ash/shell.h"
+#include "ash/common/wm_shell.h"
 #include "ash/system/chromeos/screen_security/screen_capture_tray_item.h"
 #include "ash/system/chromeos/screen_security/screen_share_tray_item.h"
 #include "ash/test/ash_test_base.h"
 #include "base/callback.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/message_center/message_center.h"
 #include "ui/views/view.h"
 
 namespace ash {
 
 // Test with unicode strings.
 const char kTestScreenCaptureAppName[] =
     "\xE0\xB2\xA0\x5F\xE0\xB2\xA0 (Screen Capture Test)";
 const char kTestScreenShareHelperName[] =
     "\xE5\xAE\x8B\xE8\x85\xBE (Screen Share Test)";
 
-SystemTray* GetSystemTray() {
-  return Shell::GetInstance()->GetPrimarySystemTray();
-}
-
-SystemTrayNotifier* GetSystemTrayNotifier() {
-  return Shell::GetInstance()->system_tray_notifier();
-}
-
 void ClickViewCenter(views::View* view) {
   gfx::Point click_location_in_local =
       gfx::Point(view->width() / 2, view->height() / 2);
   view->OnMousePressed(ui::MouseEvent(
       ui::ET_MOUSE_PRESSED, click_location_in_local, click_location_in_local,
       ui::EventTimeForNow(), ui::EF_NONE, ui::EF_NONE));
 }
 
 class ScreenTrayItemTest : public ash::test::AshTestBase {
  public:
@@ skipping 33 matching lines @@
 
 class ScreenCaptureTest : public ScreenTrayItemTest {
  public:
   ScreenCaptureTest() {}
   ~ScreenCaptureTest() override {}
 
   void SetUp() override {
     ScreenTrayItemTest::SetUp();
     // This tray item is owned by its parent system tray view and will
     // be deleted automatically when its parent is destroyed in AshTestBase.
-    ScreenTrayItem* tray_item = new ScreenCaptureTrayItem(GetSystemTray());
-    GetSystemTray()->AddTrayItem(tray_item);
-    set_tray_item(tray_item);
+    ScreenTrayItem* item = new ScreenCaptureTrayItem(GetPrimarySystemTray());
+    GetPrimarySystemTray()->AddTrayItem(item);
+    set_tray_item(item);
   }
 
   DISALLOW_COPY_AND_ASSIGN(ScreenCaptureTest);
 };
 
 class ScreenShareTest : public ScreenTrayItemTest {
  public:
   ScreenShareTest() {}
   ~ScreenShareTest() override {}
 
   void SetUp() override {
     ScreenTrayItemTest::SetUp();
     // This tray item is owned by its parent system tray view and will
     // be deleted automatically when its parent is destroyed in AshTestBase.
-    ScreenTrayItem* tray_item = new ScreenShareTrayItem(GetSystemTray());
-    GetSystemTray()->AddTrayItem(tray_item);
-    set_tray_item(tray_item);
+    ScreenTrayItem* item = new ScreenShareTrayItem(GetPrimarySystemTray());
+    GetPrimarySystemTray()->AddTrayItem(item);
+    set_tray_item(item);
   }
 
   DISALLOW_COPY_AND_ASSIGN(ScreenShareTest);
 };
 
 void TestStartAndStop(ScreenTrayItemTest* test) {
   ScreenTrayItem* tray_item = test->tray_item();
 
   EXPECT_FALSE(tray_item->is_started());
   EXPECT_EQ(0, test->stop_callback_hit_count());
@@ skipping 21 matching lines @@
   // The stop callback shouldn't be called because we stopped
   // through the notification system.
   stop_function.Run();
   EXPECT_FALSE(tray_item->is_started());
   EXPECT_EQ(0, test->stop_callback_hit_count());
 }
 
 TEST_F(ScreenCaptureTest, NotificationStartAndStop) {
   base::Closure start_function =
       base::Bind(&SystemTrayNotifier::NotifyScreenCaptureStart,
-          base::Unretained(GetSystemTrayNotifier()),
+          base::Unretained(WmShell::Get()->system_tray_notifier()),
           base::Bind(&ScreenTrayItemTest::StopCallback,
                      base::Unretained(this)),
                      base::UTF8ToUTF16(kTestScreenCaptureAppName));
 
   base::Closure stop_function =
       base::Bind(&SystemTrayNotifier::NotifyScreenCaptureStop,
-          base::Unretained(GetSystemTrayNotifier()));
+          base::Unretained(WmShell::Get()->system_tray_notifier()));
 
   TestNotificationStartAndStop(this, start_function, stop_function);
 }
 
 TEST_F(ScreenShareTest, NotificationStartAndStop) {
   base::Closure start_func =
       base::Bind(&SystemTrayNotifier::NotifyScreenShareStart,
-          base::Unretained(GetSystemTrayNotifier()),
+          base::Unretained(WmShell::Get()->system_tray_notifier()),
           base::Bind(&ScreenTrayItemTest::StopCallback,
                      base::Unretained(this)),
                      base::UTF8ToUTF16(kTestScreenShareHelperName));
 
   base::Closure stop_func =
       base::Bind(&SystemTrayNotifier::NotifyScreenShareStop,
-          base::Unretained(GetSystemTrayNotifier()));
+          base::Unretained(WmShell::Get()->system_tray_notifier()));
 
   TestNotificationStartAndStop(this, start_func, stop_func);
 }
 
 void TestNotificationView(ScreenTrayItemTest* test) {
   ScreenTrayItem* tray_item = test->tray_item();
 
   test->StartSession();
   message_center::MessageCenter* message_center =
       message_center::MessageCenter::Get();
   EXPECT_TRUE(message_center->FindVisibleNotificationById(
       tray_item->GetNotificationId()));
   test->StopSession();
 }
 
 TEST_F(ScreenCaptureTest, NotificationView) { TestNotificationView(this); }
 TEST_F(ScreenShareTest, NotificationView) { TestNotificationView(this); }
 
 void TestSystemTrayInteraction(ScreenTrayItemTest* test) {
   ScreenTrayItem* tray_item = test->tray_item();
   EXPECT_FALSE(tray_item->tray_view()->visible());
 
   const std::vector<SystemTrayItem*>& tray_items =
-      GetSystemTray()->GetTrayItems();
+      test::AshTestBase::GetPrimarySystemTray()->GetTrayItems();
   EXPECT_NE(std::find(tray_items.begin(), tray_items.end(), tray_item),
             tray_items.end());
 
   test->StartSession();
   EXPECT_TRUE(tray_item->tray_view()->visible());
 
   // The default view should be created in a new bubble.
-  GetSystemTray()->ShowDefaultView(BUBBLE_CREATE_NEW);
+  test::AshTestBase::GetPrimarySystemTray()->ShowDefaultView(BUBBLE_CREATE_NEW);
   EXPECT_TRUE(tray_item->default_view());
-  GetSystemTray()->CloseSystemBubble();
+  test::AshTestBase::GetPrimarySystemTray()->CloseSystemBubble();
   EXPECT_FALSE(tray_item->default_view());
 
   test->StopSession();
   EXPECT_FALSE(tray_item->tray_view()->visible());
 
   // The default view should not be visible because session is stopped.
-  GetSystemTray()->ShowDefaultView(BUBBLE_CREATE_NEW);
+  test::AshTestBase::GetPrimarySystemTray()->ShowDefaultView(BUBBLE_CREATE_NEW);
   EXPECT_FALSE(tray_item->default_view()->visible());
 }
 
 TEST_F(ScreenCaptureTest, SystemTrayInteraction) {
   TestSystemTrayInteraction(this);
 }
 
 TEST_F(ScreenShareTest, SystemTrayInteraction) {
   TestSystemTrayInteraction(this);
 }
 
 }  // namespace ash