Settings People Revamp: Fix CloseUI CRASH from unusual signin flow

Settings People Revamp: Fix CloseUI CRASH from unusual signin flow

There are a few unusual entry-points into the sign-in flow, i.e.
when the user has disabled Sync from Chrome Dashboard.

The crash is from a missing AllowJavascript() call for these
edge cases.

BUG=621491, 610579
Committed: https://crrev.com/6d9192a3d731bcd2f309e3edca05a4b882fb7df3
Cr-Commit-Position: refs/heads/master@{#401931}

[tommycli, 2016-06-24 00:35:37]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-06-24 00:35:37]

dbeam: PTAL, thanks!

[Dan Beam, 2016-06-24 00:44:37]

lgtm

can haz test if worth it?

[tommycli, 2016-06-24 01:17:32]

On 2016/06/24 00:44:37, Dan Beam wrote:
> lgtm
> 
> can haz test if worth it?

you can haz test. I enhanced an existing test.

[tommycli, 2016-06-24 01:17:38]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-06-24 01:17:39]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2097533003/#ps20001
(title: "enhance a test")

[commit-bot: I haz the power, 2016-06-24 01:18:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2097533003/20001

[commit-bot: I haz the power, 2016-06-24 01:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 01:27:46]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Dan Beam, 2016-06-24 18:28:21]

yay for tests!  still lgtm

[tommycli, 2016-06-24 18:36:06]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-06-24 18:36:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 19:32:34]

Description was changed from

==========
Settings People Revamp: Fix CloseUI CRASH from unusual signin flow

There are a few unusual entry-points into the sign-in flow, i.e.
when the user has disabled Sync from Chrome Dashboard.

The crash is from a missing AllowJavascript() call for these
edge cases.

BUG=621491, 610579
==========

to

==========
Settings People Revamp: Fix CloseUI CRASH from unusual signin flow

There are a few unusual entry-points into the sign-in flow, i.e.
when the user has disabled Sync from Chrome Dashboard.

The crash is from a missing AllowJavascript() call for these
edge cases.

BUG=621491, 610579

Committed: https://crrev.com/6d9192a3d731bcd2f309e3edca05a4b882fb7df3
Cr-Commit-Position: refs/heads/master@{#401931}
==========

[commit-bot: I haz the power, 2016-06-24 19:32:35]

Patchset 2 (id:??) landed as
https://crrev.com/6d9192a3d731bcd2f309e3edca05a4b882fb7df3
Cr-Commit-Position: refs/heads/master@{#401931}