Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3195)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/settings/people_handler.cc

Issue 2097533003: Settings People Revamp: Fix CloseUI CRASH from unusual signin flow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enhance a test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/people_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/people_handler.cc
diff --git a/chrome/browser/ui/webui/settings/people_handler.cc b/chrome/browser/ui/webui/settings/people_handler.cc
index 22ac4b4dc8861ea164e278a303df303edbda4655..12333121c3ebc2a1bf2423020acd30304de34379 100644
--- a/chrome/browser/ui/webui/settings/people_handler.cc
+++ b/chrome/browser/ui/webui/settings/people_handler.cc
@@ -504,6 +504,8 @@ void PeopleHandler::HandleDoSignOutOnAuthError(const base::ListValue* args) {
#if !defined(OS_CHROMEOS)
void PeopleHandler::HandleStartSignin(const base::ListValue* args) {
+ AllowJavascript();
+
// Should only be called if the user is not already signed in.
DCHECK(!SigninManagerFactory::GetForProfile(profile_)->IsAuthenticated());
bool creating_supervised_user = false;
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/people_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698