[PCv2] migrate page_cycler_v2.intl_ja_zh

[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
CQ_EXTRA_TRYBOTS omitted (relevant try bots passed)

Committed: https://crrev.com/0e902e6e9dd6919de0cacc0286bfa8cb54ebb3b0
Cr-Commit-Position: refs/heads/master@{#404057}

[kouhei (in TOK), 2016-06-27 04:27:45]

Description was changed from

==========
[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
==========

to

==========
[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[kouhei (in TOK), 2016-06-27 04:28:04]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 04:28:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2016-06-27 04:28:22]

kouhei@chromium.org changed reviewers:
+ ksakamoto@chromium.org, nednguyen@google.com

[kouhei (in TOK), 2016-06-27 04:28:22]

kouhei@chromium.org changed required reviewers:
+ nednguyen@google.com

[nednguyen, 2016-06-27 04:33:48]

https://codereview.chromium.org/2097303002/diff/1/tools/perf/benchmarks/page_...
File tools/perf/benchmarks/page_cycler_v2.py (right):

https://codereview.chromium.org/2097303002/diff/1/tools/perf/benchmarks/page_...
tools/perf/benchmarks/page_cycler_v2.py:18: 
nits: 2 blank lines between top level definitions

https://codereview.chromium.org/2097303002/diff/1/tools/perf/benchmarks/page_...
tools/perf/benchmarks/page_cycler_v2.py:43: 
Same here

https://codereview.chromium.org/2097303002/diff/1/tools/perf/benchmarks/page_...
tools/perf/benchmarks/page_cycler_v2.py:60: 
ditto

https://codereview.chromium.org/2097303002/diff/1/tools/perf/benchmarks/page_...
tools/perf/benchmarks/page_cycler_v2.py:61: class
PageCyclerIntlJaZh(_PageCyclerV2):
You will want to make sure that this is named PageCyclerV2IntlJaZh, otherwise
telemetry code that discovers benchmarks get confused since it discovers all
classes indexed by their names.

I will add a test coverage to make sure that no two benchmark has same class
names due to this limitation.

[kouhei (in TOK), 2016-06-27 04:37:02]

https://codereview.chromium.org/2097303002/diff/1/tools/perf/benchmarks/page_...
File tools/perf/benchmarks/page_cycler_v2.py (right):

https://codereview.chromium.org/2097303002/diff/1/tools/perf/benchmarks/page_...
tools/perf/benchmarks/page_cycler_v2.py:18: 
On 2016/06/27 04:33:48, nednguyen wrote:
> nits: 2 blank lines between top level definitions

Done.

https://codereview.chromium.org/2097303002/diff/1/tools/perf/benchmarks/page_...
tools/perf/benchmarks/page_cycler_v2.py:43: 
On 2016/06/27 04:33:48, nednguyen wrote:
> Same here

Done.

https://codereview.chromium.org/2097303002/diff/1/tools/perf/benchmarks/page_...
tools/perf/benchmarks/page_cycler_v2.py:60: 
On 2016/06/27 04:33:48, nednguyen wrote:
> ditto

Done.

https://codereview.chromium.org/2097303002/diff/1/tools/perf/benchmarks/page_...
tools/perf/benchmarks/page_cycler_v2.py:61: class
PageCyclerIntlJaZh(_PageCyclerV2):
On 2016/06/27 04:33:48, nednguyen wrote:
> You will want to make sure that this is named PageCyclerV2IntlJaZh, otherwise
> telemetry code that discovers benchmarks get confused since it discovers all
> classes indexed by their names.
> 
> I will add a test coverage to make sure that no two benchmark has same class
> names due to this limitation.

Done.

[nednguyen, 2016-06-27 04:40:54]

lgtm

https://codereview.chromium.org/2097303002/diff/20001/tools/perf/benchmarks/p...
File tools/perf/benchmarks/page_cycler_v2.py (right):

https://codereview.chromium.org/2097303002/diff/20001/tools/perf/benchmarks/p...
tools/perf/benchmarks/page_cycler_v2.py:52: options = {'pageset_repeat': 2}
Should this {'pageset_repeat': 2} be moved to the based _PageCyclerV2 class so
that it applies to all the pcv2 benchmarks?

[kouhei (in TOK), 2016-06-27 04:43:00]

https://codereview.chromium.org/2097303002/diff/20001/tools/perf/benchmarks/p...
File tools/perf/benchmarks/page_cycler_v2.py (right):

https://codereview.chromium.org/2097303002/diff/20001/tools/perf/benchmarks/p...
tools/perf/benchmarks/page_cycler_v2.py:52: options = {'pageset_repeat': 2}
On 2016/06/27 04:40:54, nednguyen wrote:
> Should this {'pageset_repeat': 2} be moved to the based _PageCyclerV2 class so
> that it applies to all the pcv2 benchmarks?

Done.

[kouhei (in TOK), 2016-06-27 04:43:04]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2016-06-27 04:43:04]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2097303002/#ps40001
(title: "move options -> _PageCyclerV2")

[commit-bot: I haz the power, 2016-06-27 04:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 06:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 06:43:55]

Try jobs failed on following builders:
  android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
  winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)

[kouhei (in TOK), 2016-06-28 03:12:21]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 03:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 04:37:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 04:37:01]

Dry run: Try jobs failed on following builders:
  mac_retina_perf_cq on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)

[kouhei (in TOK), 2016-06-28 06:38:17]

On 2016/06/28 04:37:01, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   mac_retina_perf_cq on tryserver.chromium.perf (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)

Looking into this but no clue atm.
At least, Android failure doesn't repro locally.

[nednguyen, 2016-06-28 13:13:39]

On 2016/06/28 06:38:17, kouhei wrote:
> On 2016/06/28 04:37:01, commit-bot: I haz the power wrote:
> > Dry run: Try jobs failed on following builders:
> >   mac_retina_perf_cq on tryserver.chromium.perf (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)
> 
> Looking into this but no clue atm.
> At least, Android failure doesn't repro locally.

The failed pages are the same: 
[  FAILED  ] 
http://www.google.com.hk/#q=%E9%82%84%E6%8F%90%E4%BE%9B&fp=c44d333e710cb480
[  FAILED  ]  http://udn.com/NEWS/mainpage.shtml

If needed, we can comment out those pages for now & put it in the backlog to
investigate those.

[kouhei (in TOK), 2016-06-28 13:27:44]

On 2016/06/28 13:13:39, nednguyen wrote:
> On 2016/06/28 06:38:17, kouhei wrote:
> > On 2016/06/28 04:37:01, commit-bot: I haz the power wrote:
> > > Dry run: Try jobs failed on following builders:
> > >   mac_retina_perf_cq on tryserver.chromium.perf (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)
> > 
> > Looking into this but no clue atm.
> > At least, Android failure doesn't repro locally.
> 
> The failed pages are the same: 
> [  FAILED  ] 
> http://www.google.com.hk/#q=%E9%82%84%E6%8F%90%E4%BE%9B&fp=c44d333e710cb480
> [  FAILED  ]  http://udn.com/NEWS/mainpage.shtml
> 
> If needed, we can comment out those pages for now & put it in the backlog to
> investigate those.

managed to repro locally. I'll take a look tomorrow.

[kouhei (in TOK), 2016-07-06 01:33:07]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2016-07-06 01:33:07]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2097303002/#ps80001
(title: "remove_workaround")

[commit-bot: I haz the power, 2016-07-06 01:33:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 01:33:23]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[kouhei (in TOK), 2016-07-06 01:34:14]

On 2016/06/28 13:27:44, kouhei wrote:
> On 2016/06/28 13:13:39, nednguyen wrote:
> > On 2016/06/28 06:38:17, kouhei wrote:
> > > On 2016/06/28 04:37:01, commit-bot: I haz the power wrote:
> > > > Dry run: Try jobs failed on following builders:
> > > >   mac_retina_perf_cq on tryserver.chromium.perf (JOB_FAILED,
> > > >
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)
> > > 
> > > Looking into this but no clue atm.
> > > At least, Android failure doesn't repro locally.
> > 
> > The failed pages are the same: 
> > [  FAILED  ] 
> > http://www.google.com.hk/#q=%E9%82%84%E6%8F%90%E4%BE%9B&fp=c44d333e710cb480
> > [  FAILED  ]  http://udn.com/NEWS/mainpage.shtml
> > 
> > If needed, we can comment out those pages for now & put it in the backlog to
> > investigate those.
> 
> managed to repro locally. I'll take a look tomorrow.
Fix CL landed at catapult: https://codereview.chromium.org/2127483002/
landing this

[commit-bot: I haz the power, 2016-07-06 02:00:58]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 02:31:39]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 03:01:13]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 03:31:16]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 03:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 03:46:23]

Try jobs failed on following builders:
  android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)

[kouhei (in TOK), 2016-07-06 03:47:00]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2016-07-06 03:47:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 03:47:12]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 04:02:00]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 04:31:16]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 05:01:20]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 05:31:06]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 06:01:05]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 06:31:12]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 06:49:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 06:49:29]

Try jobs failed on following builders:
  winx64_10_perf_cq on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)

[kouhei (in TOK), 2016-07-06 06:50:02]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2016-07-06 06:50:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 06:50:23]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 07:01:15]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 07:31:04]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 08:01:27]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 08:31:37]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 09:01:30]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 09:31:29]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 10:01:00]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 10:31:28]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 11:01:32]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 11:31:05]

There were warnings when CQ was processing your CL:
 * CQ_EXTRA_TRYBOTS flag is deprecated and will soon be removed. Use
CQ_INCLUDE_TRYBOTS instead.

[commit-bot: I haz the power, 2016-07-06 11:50:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 11:51:00]

Try jobs failed on following builders:
  winx64_10_perf_cq on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)

[nednguyen, 2016-07-07 00:33:47]

Description was changed from

==========
[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cqtryserver.chromium.perf:mac_retina_perf_cq
==========

[nednguyen, 2016-07-07 00:34:36]

On 2016/07/06 11:51:00, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   winx64_10_perf_cq on tryserver.chromium.perf (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)

Removed ;tryserver.chromium.perf:winx64_10_perf_cq; because it keeps having
compile error.

+Ethan: I thought you removed winx64 from CQ_EXTRA_TRYBOTS?

[nednguyen, 2016-07-07 00:34:43]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-07-07 00:34:53]

nednguyen@google.com changed reviewers:
+ eakuefner@chromium.org

[commit-bot: I haz the power, 2016-07-07 00:35:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 00:35:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 00:35:24]

Transient error: Too many
"tryserver.chromium.perf:android_s5_perf_cqtryserver.chromium.perf:mac_retina_perf_cq"
delimiters in ":".
Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".

[kouhei (in TOK), 2016-07-07 01:34:52]

On 2016/07/07 00:35:24, commit-bot: I haz the power wrote:
> Transient error: Too many
>
"tryserver.chromium.perf:android_s5_perf_cqtryserver.chromium.perf:mac_retina_perf_cq"
> delimiters in ":".
> Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".

Let me remove the line as we already confirmed that the bots pass

[kouhei (in TOK), 2016-07-07 01:35:15]

Description was changed from

==========
[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cqtryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
CQ_EXTRA_TRYBOTS omitted (relevant try bots passed)
==========

[kouhei (in TOK), 2016-07-07 01:35:21]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2016-07-07 01:35:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 01:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 01:44:37]

Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[kouhei (in TOK), 2016-07-07 01:47:12]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2016-07-07 01:47:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 03:13:47]

Description was changed from

==========
[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
CQ_EXTRA_TRYBOTS omitted (relevant try bots passed)
==========

to

==========
[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
CQ_EXTRA_TRYBOTS omitted (relevant try bots passed)
==========

[commit-bot: I haz the power, 2016-07-07 03:13:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-07 03:13:52]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 03:16:38]

Description was changed from

==========
[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
CQ_EXTRA_TRYBOTS omitted (relevant try bots passed)
==========

to

==========
[PCv2] migrate page_cycler_v2.intl_ja_zh

BUG=611329
CQ_EXTRA_TRYBOTS omitted (relevant try bots passed)

Committed: https://crrev.com/0e902e6e9dd6919de0cacc0286bfa8cb54ebb3b0
Cr-Commit-Position: refs/heads/master@{#404057}
==========

[commit-bot: I haz the power, 2016-07-07 03:16:40]

Patchset 5 (id:??) landed as
https://crrev.com/0e902e6e9dd6919de0cacc0286bfa8cb54ebb3b0
Cr-Commit-Position: refs/heads/master@{#404057}