Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: tools/perf/benchmarks/page_cycler_v2.py

Issue 2097303002: [PCv2] migrate page_cycler_v2.intl_ja_zh (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ned's review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/intl_ja_zh.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """The page cycler v2. 5 """The page cycler v2.
6 6
7 For details, see design doc: 7 For details, see design doc:
8 https://docs.google.com/document/d/1EZQX-x3eEphXupiX-Hq7T4Afju5_sIdxPWYetj7ynd0 8 https://docs.google.com/document/d/1EZQX-x3eEphXupiX-Hq7T4Afju5_sIdxPWYetj7ynd0
9 """ 9 """
10 10
11 from core import perf_benchmark 11 from core import perf_benchmark
12 import page_sets 12 import page_sets
13 13
14 from telemetry import benchmark 14 from telemetry import benchmark
15 from telemetry.page import cache_temperature 15 from telemetry.page import cache_temperature
16 from telemetry.timeline import tracing_category_filter 16 from telemetry.timeline import tracing_category_filter
17 from telemetry.web_perf import timeline_based_measurement 17 from telemetry.web_perf import timeline_based_measurement
18 18
19 19
20 # crbug.com/619254
21 @benchmark.Disabled('reference')
20 class _PageCyclerV2(perf_benchmark.PerfBenchmark): 22 class _PageCyclerV2(perf_benchmark.PerfBenchmark):
21 def CreateTimelineBasedMeasurementOptions(self): 23 def CreateTimelineBasedMeasurementOptions(self):
22 cat_filter = tracing_category_filter.TracingCategoryFilter( 24 cat_filter = tracing_category_filter.TracingCategoryFilter(
23 filter_string='blink.console,navigation,blink.user_timing,loading') 25 filter_string='blink.console,navigation,blink.user_timing,loading')
24 26
25 # Below categories are needed for first-meaningful-paint computation. 27 # Below categories are needed for first-meaningful-paint computation.
26 cat_filter.AddDisabledByDefault('disabled-by-default-blink.debug.layout') 28 cat_filter.AddDisabledByDefault('disabled-by-default-blink.debug.layout')
27 cat_filter.AddIncludedCategory('devtools.timeline') 29 cat_filter.AddIncludedCategory('devtools.timeline')
28 30
29 tbm_options = timeline_based_measurement.Options( 31 tbm_options = timeline_based_measurement.Options(
30 overhead_level=cat_filter) 32 overhead_level=cat_filter)
31 tbm_options.SetTimelineBasedMetric('firstPaintMetric') 33 tbm_options.SetTimelineBasedMetric('firstPaintMetric')
32 return tbm_options 34 return tbm_options
33 35
34 # crbug.com/619254 36 @classmethod
35 @benchmark.Disabled('reference') 37 def ShouldDisable(cls, possible_browser):
38 # crbug.com/616781
39 if (cls.IsSvelte(possible_browser) or
40 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or
41 possible_browser.platform.GetDeviceTypeName() == 'AOSP on BullHead'):
42 return True
43 return False
44
45
36 class PageCyclerV2Typical25(_PageCyclerV2): 46 class PageCyclerV2Typical25(_PageCyclerV2):
37 """Page load time benchmark for a 25 typical web pages. 47 """Page load time benchmark for a 25 typical web pages.
38 48
39 Designed to represent typical, not highly optimized or highly popular web 49 Designed to represent typical, not highly optimized or highly popular web
40 sites. Runs against pages recorded in June, 2014. 50 sites. Runs against pages recorded in June, 2014.
41 """ 51 """
42 options = {'pageset_repeat': 2} 52 options = {'pageset_repeat': 2}
nednguyen 2016/06/27 04:40:54 Should this {'pageset_repeat': 2} be moved to the
kouhei (in TOK) 2016/06/27 04:43:00 Done.
43 53
44 @classmethod 54 @classmethod
45 def Name(cls): 55 def Name(cls):
46 return 'page_cycler_v2.typical_25' 56 return 'page_cycler_v2.typical_25'
47 57
48 @classmethod
49 def ShouldDisable(cls, possible_browser):
50 # crbug.com/616781
51 if (cls.IsSvelte(possible_browser) or
52 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or
53 possible_browser.platform.GetDeviceTypeName() == 'AOSP on BullHead'):
54 return True
55 return False
56
57 def CreateStorySet(self, options): 58 def CreateStorySet(self, options):
58 return page_sets.Typical25PageSet(run_no_page_interactions=True, 59 return page_sets.Typical25PageSet(run_no_page_interactions=True,
59 cache_temperatures=[ 60 cache_temperatures=[
60 cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM]) 61 cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
62
63
64 class PageCyclerV2IntlJaZh(_PageCyclerV2):
65 """Page load time benchmark for a variety of pages in Japanese and Chinese.
66
67 Runs against pages recorded in April, 2013.
68 """
69 page_set = page_sets.IntlJaZhPageSet
70
71 @classmethod
72 def Name(cls):
73 return 'page_cycler_v2.intl_ja_zh'
74
75 def CreateStorySet(self, options):
76 return page_sets.IntlJaZhPageSet(cache_temperatures=[
77 cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
OLDNEW
« no previous file with comments | « no previous file | tools/perf/page_sets/intl_ja_zh.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698