Remove traces of removed Mac/Win GN builders.

Remove traces of removed Mac/Win GN builders.

R=martiniss@chromium.org, kjellander@chromium.org
BUG=618468, 605318
Committed: https://chromium.googlesource.com/chromium/tools/build/+/f7b7c2a06a5b09e56df379be5de85a926dc1e01a

[Dirk Pranke, 2016-06-25 05:10:47]

https://codereview.chromium.org/2097223002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py (right):

https://codereview.chromium.org/2097223002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py:29:
AddGNBuilder(chromium_mac.SPEC, 'Mac Builder (dbg)', 'Mac GN (dbg)')
@kjellander - I had to swap these in since the old builder definitions are gone.
The new builder definitions are somewhat different, but I'm not sure it matters
since the GYP_DEFINES differences are harmless and the actual list of things to
build and run will be pulled from the src-side files.

https://codereview.chromium.org/2097223002/diff/1/tests/masters_recipes_test.py
File tests/masters_recipes_test.py (left):

https://codereview.chromium.org/2097223002/diff/1/tests/masters_recipes_test....
tests/masters_recipes_test.py:77: DEPRECATED_BUILDERS = {
I had originally planned to leave this logic in, because I thought it would be
useful in the future when renaming builders, but it turns out this was useless
because the annotated_run.py script reads the factory properties directly from
the master config, and so if the builder has been removed from the master in the
repo, the slave will fail to run even if the master still thinks the slave
exists.

As a result, it's not clear to me that there's any way to rename or remove
builders without causing failed builds ...

[kjellander_chromium, 2016-06-27 15:40:37]

kjellander@chromium.org changed reviewers:
+ phoglund@chromium.org

[Dirk Pranke, 2016-06-27 16:21:22]

On 2016/06/27 15:40:38, kjellander_cr (OOO July31) wrote:

did you mean to type something?

[kjellander_chromium, 2016-06-28 12:47:15]

On 2016/06/27 16:21:22, Dirk Pranke wrote:
> On 2016/06/27 15:40:38, kjellander_cr (OOO July31) wrote:
> 
> did you mean to type something?

Sorry, I just added phoglund since I'm OOO (was on mobile so I didn't bother
typing any message).

[kjellander_chromium, 2016-06-28 12:53:10]

I had a look at this now since phoglund is OOO the rest of the week as well.
lgtm since this shouldn't break our builders.

I guess we should get rid of our Win+Mac GN bots now as well?

[Dirk Pranke, 2016-06-28 16:17:03]

On 2016/06/28 12:53:10, kjellander_cr (OOO July31) wrote:
> I had a look at this now since phoglund is OOO the rest of the week as well.
> lgtm since this shouldn't break our builders.
> 
> I guess we should get rid of our Win+Mac GN bots now as well?

I probably would, yes.

[Dirk Pranke, 2016-06-29 01:38:13]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-06-29 01:38:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:42:35]

Description was changed from

==========
Remove traces of removed Mac/Win GN builders.

R=martiniss@chromium.org, kjellander@chromium.org
BUG=618468, 605318
==========

to

==========
Remove traces of removed Mac/Win GN builders.

R=martiniss@chromium.org, kjellander@chromium.org
BUG=618468, 605318

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/f7b7c2a06a5b09e56df3...
==========

[commit-bot: I haz the power, 2016-06-29 01:42:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/f7b7c2a06a5b09e56df3...