scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py - Issue 2097223002: Remove traces of removed Mac/Win GN builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py

Issue 2097223002: Remove traces of removed Mac/Win GN builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/chromium_mac.py ('k') | scripts/slave/recipe_modules/chromium_tests/chromium_win.py » ('j') | tests/masters_recipes_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py b/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py

index 0532c6aec498c3418b8842819d7bf8059e0392bf..d14ec8513395e48d17260c9823a1e41ecda9ebdf 100644

--- a/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py

+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py

@@ -25,8 +25,8 @@ def AddGNBuilder(spec, name, dest_name=None):

SPEC['builders'][dest_name or name] = copy.deepcopy(spec['builders'][name])

-AddGNBuilder(chromium_mac.SPEC, 'Mac GN')

-AddGNBuilder(chromium_mac.SPEC, 'Mac GN (dbg)')

+AddGNBuilder(chromium_mac.SPEC, 'Mac Builder', 'Mac GN')

+AddGNBuilder(chromium_mac.SPEC, 'Mac Builder (dbg)', 'Mac GN (dbg)')

Dirk Pranke 2016/06/25 05:10:46 @kjellander - I had to swap these in since the old

AddGNBuilder(chromium_win.SPEC, 'Win x64 Builder', 'Win x64 GN')

AddGNBuilder(chromium_win.SPEC, 'Win x64 Builder (dbg)', 'Win x64 GN (dbg)')