Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2097093002: [Typed OM] Rename cssString methods to cssText (Closed)

Created:
4 years, 6 months ago by meade_UTC10
Modified:
4 years, 5 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@rename-transformvalue
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Typed OM] Rename cssString methods to cssText Spec for CSSStyleValue: https://drafts.css-houdini.org/css-typed-om/#dom-cssstylevalue-csstext Spec for CSSTransformComponent: https://drafts.css-houdini.org/css-typed-om/#dom-csstransformcomponent-csstext BUG=545318 Committed: https://crrev.com/f8a9be7117dbc700532bddff778a8742f23092d3 Cr-Commit-Position: refs/heads/master@{#402335}

Patch Set 1 #

Patch Set 2 : Update missed cssString -> cssTexts #

Patch Set 3 : Update usage in csspaint logging for tests #

Patch Set 4 : Update usage in csspaint logging for tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -176 lines) Patch
M third_party/WebKit/LayoutTests/csspaint/resources/generate-paint-style-logging.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/border-top-width.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/computedStylePropertyMap.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/pseudo-elements.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/computedstyle/width.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssAngleValue.html View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssCalcLength.html View 1 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssKeywordValue.html View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssMatrix.html View 1 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssNumberValue.html View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssPerspective.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssPositionValue.html View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssRotation.html View 1 3 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssScale.html View 1 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSimpleLength.html View 1 1 chunk +33 lines, -33 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSkew.html View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html View 1 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_delete.html View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll.html View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iteration.html View 3 chunks +22 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iterationWithModification.html View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet.html View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/unsupported-properties.html View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSLengthValue.idl View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSStyleValue.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2099513002 Patch 60001

Messages

Total messages: 9 (4 generated)
meade_UTC10
4 years, 6 months ago (2016-06-24 16:03:07 UTC) #2
Timothy Loh
On 2016/06/24 16:03:07, Eddy wrote: lgtm
4 years, 5 months ago (2016-06-27 00:07:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097093002/60001
4 years, 5 months ago (2016-06-27 22:30:19 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-27 23:52:17 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 23:54:39 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f8a9be7117dbc700532bddff778a8742f23092d3
Cr-Commit-Position: refs/heads/master@{#402335}

Powered by Google App Engine
This is Rietveld 408576698