net/http/http_auth_cache.h - Issue 2097043002: Clear HTTP auth data on clearing browsing data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_cache.h

Issue 2097043002: Clear HTTP auth data on clearing browsing data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review issues Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_cache.h

diff --git a/net/http/http_auth_cache.h b/net/http/http_auth_cache.h

index 9190e42c50899951eac307e3afa674cdb7175878..88a33234dd12f3ca6647cc1a59207be81a47dc38 100644

--- a/net/http/http_auth_cache.h

+++ b/net/http/http_auth_cache.h

@@ -162,8 +162,8 @@ class NET_EXPORT_PRIVATE HttpAuthCache {

HttpAuth::Scheme scheme,

const AuthCredentials& credentials);

- // Clears the cache.

- void Clear();

+ // Clears cache entries created within |duration| of base::TimeTicks::Now().

+ void Clear(base::TimeDelta duration);

mmenke 2016/07/29 14:08:48 This method name is unclear. Maybe make it take a

// Updates a stale digest entry on server |origin| for realm |realm| and

// scheme |scheme|. The cached auth challenge is replaced with

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover.cc ('k') | net/http/http_auth_cache.cc » ('j') | no next file with comments »