Clear HTTP auth data on clearing browsing data

net/http/http_auth_cache.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_AUTH_CACHE_H_
 #define NET_HTTP_HTTP_AUTH_CACHE_H_
 
 #include <stddef.h>
 
 #include <list>
 #include <string>
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/time/time.h"
 #include "net/base/net_export.h"
 #include "net/http/http_auth.h"
 #include "url/gurl.h"
 
 namespace net {
 
 // HttpAuthCache stores HTTP authentication identities and challenge info.
 // For each (origin, realm, scheme) triple the cache stores a
 // HttpAuthCache::Entry, which holds:
 //   - the origin server {protocol scheme, host, port}
 //   - the last identity used (username/password)
 //   - the last auth handler used (contains realm and authentication scheme)
 //   - the list of paths which used this realm
 // Entries can be looked up by either (origin, realm, scheme) or (origin, path).
 class NET_EXPORT_PRIVATE HttpAuthCache {

[mmenke, 2016/07/29 14:08:48]

This should presumably be NET_EXPORT, if we're using it externally.

  public:
   class NET_EXPORT_PRIVATE Entry {
    public:
     Entry(const Entry& other);
     ~Entry();
 
     const GURL& origin() const {
       return origin_;
     }
 
@@ skipping 114 matching lines @@
   //   |origin|   - the {scheme, host, port} of the server.
   //   |realm|    - case sensitive realm string.
   //   |scheme|   - the authentication scheme (i.e. basic, negotiate).
   //   |credentials| - the credentials to match.
   //   returns    - true if an entry was removed.
   bool Remove(const GURL& origin,
               const std::string& realm,
               HttpAuth::Scheme scheme,
               const AuthCredentials& credentials);
 
-  // Clears the cache.
-  void Clear();
+  // Clears cache entries created within |duration| of base::TimeTicks::Now().
+  void Clear(base::TimeDelta duration);

[mmenke, 2016/07/29 14:08:48]

This method name is unclear.  Maybe make it take a base::TimeTicks, and call it
Clear[Entries]Since, or Clear[Entries]AddedSince, or somesuch?  Suppose could
call it ClearEntriesAddedWithin

 
   // Updates a stale digest entry on server |origin| for realm |realm| and
   // scheme |scheme|. The cached auth challenge is replaced with
   // |auth_challenge| and the nonce count is reset.
   // |UpdateStaleChallenge()| returns true if a matching entry exists in the
   // cache, false otherwise.
   bool UpdateStaleChallenge(const GURL& origin,
                             const std::string& realm,
                             HttpAuth::Scheme scheme,
                             const std::string& auth_challenge);
 
   // Copies all entries from |other| cache.
   void UpdateAllFrom(const HttpAuthCache& other);
 
  private:
   typedef std::list<Entry> EntryList;
   EntryList entries_;
 };
 
 // An authentication realm entry.
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_AUTH_CACHE_H_