Clear HTTP auth data on clearing browsing data

net/http/http_auth_cache.cc

Index: net/http/http_auth_cache.cc
diff --git a/net/http/http_auth_cache.cc b/net/http/http_auth_cache.cc
index 7a3a4e0f6714cb9b927af8d6c17fad4d0e8c12ae..71d5082c1d85b629ffe877db5174cfa0c8e5be5e 100644
--- a/net/http/http_auth_cache.cc
+++ b/net/http/http_auth_cache.cc
@@ -252,8 +252,24 @@ bool HttpAuthCache::Remove(const GURL& origin,
   return false;
 }
 
-void HttpAuthCache::Clear() {
-  entries_.clear();
+void HttpAuthCache::Clear(base::Time delete_begin, base::Time delete_end) {
+  int64_t begin_millis =
+      delete_begin.is_null()
+          ? 0
+          : (delete_begin - base::Time::UnixEpoch()).InMilliseconds();

[msramek, 2016/06/30 11:36:20]

Can you use base::Time::ToTimeT() to do these conversions?

[Tomasz Moniuszko, 2016/07/01 12:44:02]

There's a TODO saying base::Time::ToTimeT() should be removed. Should I use it
anyway?

[msramek, 2016/07/01 13:19:40]

I would say yes. The TODO says that the function should be removed when no one
uses time_t anymore, but if HttpAuthCache still does use it, I think that's
fair.

[Tomasz Moniuszko, 2016/07/01 14:54:39]

Done.

+  int64_t end_millis =
+      delete_end.is_null()
+          ? std::numeric_limits<int64_t>::max()
+          : (delete_end - base::Time::UnixEpoch()).InMilliseconds();
+
+  base::TimeTicks unix_epoch = base::TimeTicks::UnixEpoch();
+
+  entries_.remove_if(
+      [begin_millis, end_millis, unix_epoch](const Entry& entry) {
+        int64_t creation_millis =
+            (entry.creation_time_ - unix_epoch).InMilliseconds();
+        return creation_millis >= begin_millis && creation_millis <= end_millis;

[msramek, 2016/06/30 11:36:20]

BrowsingDataRemover always uses half-closed intervals for deletion (i.e. <
instead of <=).

[Tomasz Moniuszko, 2016/07/01 12:44:02]

Done.

+      });
 }
 
 bool HttpAuthCache::UpdateStaleChallenge(const GURL& origin,