Clear HTTP auth data on clearing browsing data

net/http/http_auth_cache.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_auth_cache.h"
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
 
@@ skipping 234 matching lines @@
       if (credentials.Equals(it->credentials())) {
         entries_.erase(it);
         return true;
       }
       return false;
     }
   }
   return false;
 }
 
-void HttpAuthCache::Clear() {
-  entries_.clear();
+void HttpAuthCache::Clear(base::Time delete_begin, base::Time delete_end) {
+  int64_t begin_millis =
+      delete_begin.is_null()
+          ? 0
+          : (delete_begin - base::Time::UnixEpoch()).InMilliseconds();

[msramek, 2016/06/30 11:36:20]

Can you use base::Time::ToTimeT() to do these conversions?

[Tomasz Moniuszko, 2016/07/01 12:44:02]

There's a TODO saying base::Time::ToTimeT() should be removed. Should I use it
anyway?

[msramek, 2016/07/01 13:19:40]

I would say yes. The TODO says that the function should be removed when no one
uses time_t anymore, but if HttpAuthCache still does use it, I think that's
fair.

[Tomasz Moniuszko, 2016/07/01 14:54:39]

Done.

+  int64_t end_millis =
+      delete_end.is_null()
+          ? std::numeric_limits<int64_t>::max()
+          : (delete_end - base::Time::UnixEpoch()).InMilliseconds();
+
+  base::TimeTicks unix_epoch = base::TimeTicks::UnixEpoch();
+
+  entries_.remove_if(
+      [begin_millis, end_millis, unix_epoch](const Entry& entry) {
+        int64_t creation_millis =
+            (entry.creation_time_ - unix_epoch).InMilliseconds();
+        return creation_millis >= begin_millis && creation_millis <= end_millis;

[msramek, 2016/06/30 11:36:20]

BrowsingDataRemover always uses half-closed intervals for deletion (i.e. <
instead of <=).

[Tomasz Moniuszko, 2016/07/01 12:44:02]

Done.

+      });
 }
 
 bool HttpAuthCache::UpdateStaleChallenge(const GURL& origin,
                                          const std::string& realm,
                                          HttpAuth::Scheme scheme,
                                          const std::string& auth_challenge) {
   HttpAuthCache::Entry* entry = Lookup(origin, realm, scheme);
   if (!entry)
     return false;
   entry->UpdateStaleChallenge(auth_challenge);
@@ skipping 12 matching lines @@
     // Copy all other paths.
     for (Entry::PathList::const_reverse_iterator it2 = ++it->paths_.rbegin();
          it2 != it->paths_.rend(); ++it2)
       entry->AddPath(*it2);
     // Copy nonce count (for digest authentication).
     entry->nonce_count_ = it->nonce_count_;
   }
 }
 
 }  // namespace net