Clear HTTP auth data on clearing browsing data

chrome/browser/browsing_data/browsing_data_remover.cc

Index: chrome/browser/browsing_data/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc
index c58ab51a4923239b8d8d0f3ea16a5e224ae75b50..de2f881600c1aff31878fe6bfa9ecb9eae133833 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover.cc
@@ -837,7 +837,10 @@ void BrowsingDataRemover::RemoveImpl(
     web_cache::WebCacheManager::GetInstance()->ClearCache();
 
     content::RecordAction(UserMetricsAction("ClearBrowsingData_Cache"));
+  }
 
+  if (remove_mask & REMOVE_CACHE || remove_mask & REMOVE_COOKIES ||
+      remove_mask & REMOVE_PASSWORDS) {

[msramek, 2016/06/30 11:36:20]

This is not correct.

Yes, you will delete the HTTP auth data when user chooses to REMOVE_CACHE,
REMOVE_COOKIES, or REMOVE_PASSWORDS.

But StoragePartitionHttpCacheDataRemover does a lot more than that, it wipes the
entire HTTP and media caches. It makes no sense to do that if the user just
wanted to delete passwords.

We should not involve StoragePartitionHttpCacheDataRemover at all. Instead, we
should call http_auth_cache()->Clear() directly from BrowsingDataRemover. It
might require you jumping to the IO thread and back - in that case, check out
ClearHostnameResolutionCacheOnIOThread in this file for an example how to do
that.

[Tomasz Moniuszko, 2016/07/01 12:44:02]

Done.

     waiting_for_clear_cache_ = true;
     // StoragePartitionHttpCacheDataRemover deletes itself when it is done.
     if (filter_builder.IsEmptyBlacklist()) {
@@ -854,7 +857,9 @@ void BrowsingDataRemover::RemoveImpl(
               ->Remove(base::Bind(&BrowsingDataRemover::ClearedCache,
                                   weak_ptr_factory_.GetWeakPtr()));
     }
+  }
 
+  if (remove_mask & REMOVE_CACHE) {
 #if !defined(DISABLE_NACL)
     waiting_for_clear_nacl_cache_ = true;