Clear HTTP auth data on clearing browsing data

chrome/browser/browsing_data/browsing_data_remover.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_remover.h"
 
 #include <map>
 #include <set>
 #include <string>
 
@@ skipping 819 matching lines @@
       if (data_manager)
         data_manager->Refresh();
     }
   }
 
   if (remove_mask & REMOVE_CACHE) {
     // Tell the renderers to clear their cache.
     web_cache::WebCacheManager::GetInstance()->ClearCache();
 
     content::RecordAction(UserMetricsAction("ClearBrowsingData_Cache"));
+  }
 
+  if (remove_mask & REMOVE_CACHE || remove_mask & REMOVE_COOKIES ||
+      remove_mask & REMOVE_PASSWORDS) {

[msramek, 2016/06/30 11:36:20]

This is not correct.

Yes, you will delete the HTTP auth data when user chooses to REMOVE_CACHE,
REMOVE_COOKIES, or REMOVE_PASSWORDS.

But StoragePartitionHttpCacheDataRemover does a lot more than that, it wipes the
entire HTTP and media caches. It makes no sense to do that if the user just
wanted to delete passwords.

We should not involve StoragePartitionHttpCacheDataRemover at all. Instead, we
should call http_auth_cache()->Clear() directly from BrowsingDataRemover. It
might require you jumping to the IO thread and back - in that case, check out
ClearHostnameResolutionCacheOnIOThread in this file for an example how to do
that.

[Tomasz Moniuszko, 2016/07/01 12:44:02]

Done.

     waiting_for_clear_cache_ = true;
     // StoragePartitionHttpCacheDataRemover deletes itself when it is done.
     if (filter_builder.IsEmptyBlacklist()) {
       browsing_data::StoragePartitionHttpCacheDataRemover::CreateForRange(
           BrowserContext::GetDefaultStoragePartition(profile_),
           delete_begin_, delete_end_)
           ->Remove(base::Bind(&BrowsingDataRemover::ClearedCache,
                               weak_ptr_factory_.GetWeakPtr()));
     } else {
       browsing_data::StoragePartitionHttpCacheDataRemover::
           CreateForURLsAndRange(
               BrowserContext::GetDefaultStoragePartition(profile_),
               filter, delete_begin_, delete_end_)
               ->Remove(base::Bind(&BrowsingDataRemover::ClearedCache,
                                   weak_ptr_factory_.GetWeakPtr()));
     }
+  }
 
+  if (remove_mask & REMOVE_CACHE) {
 #if !defined(DISABLE_NACL)
     waiting_for_clear_nacl_cache_ = true;
 
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(&ClearNaClCacheOnIOThread,
                    UIThreadTrampoline(
                        base::Bind(&BrowsingDataRemover::ClearedNaClCache,
                                   weak_ptr_factory_.GetWeakPtr()))));
 
@@ skipping 468 matching lines @@
   waiting_for_clear_domain_reliability_monitor_ = false;
   NotifyIfDone();
 }
 
 // static
 BrowsingDataRemover::CallbackSubscription
     BrowsingDataRemover::RegisterOnBrowsingDataRemovedCallback(
         const BrowsingDataRemover::Callback& callback) {
   return GetOnBrowsingDataRemovedCallbacks()->Add(callback);
 }