Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2097003003: remove experimental treat-skcolor-as-srgb flag (Closed)

Created:
4 years, 6 months ago by reed1
Modified:
4 years, 6 months ago
Reviewers:
Brian Osman
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove experimental treat-skcolor-as-srgb flag BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2097003003 Committed: https://skia.googlesource.com/skia/+/a84d6606f5f53b8e1a42d55676e4f1ea47be5575

Patch Set 1 #

Patch Set 2 : update skiaserver #

Patch Set 3 : update tests #

Total comments: 2

Patch Set 4 : fix toSkColor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -148 lines) Patch
M samplecode/SampleApp.cpp View 3 chunks +1 line, -8 lines 0 comments Download
M src/core/SkColor.cpp View 1 2 3 2 chunks +4 lines, -8 lines 0 comments Download
M src/core/SkPM4fPriv.h View 2 chunks +1 line, -3 lines 0 comments Download
M tests/SkColor4fTest.cpp View 1 2 3 chunks +0 lines, -66 lines 0 comments Download
M tools/skiaserve/Request.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/skiaserve/Request.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
D tools/skiaserve/urlhandlers/SRGBModeHandler.cpp View 1 1 chunk +0 lines, -42 lines 0 comments Download
M tools/skiaserve/urlhandlers/UrlHandler.h View 1 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
reed1
4 years, 6 months ago (2016-06-24 15:52:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097003003/20001
4 years, 6 months ago (2016-06-24 15:59:42 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/9258)
4 years, 6 months ago (2016-06-24 16:09:37 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097003003/40001
4 years, 6 months ago (2016-06-24 16:38:39 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 16:57:51 UTC) #11
reed1
ptal
4 years, 6 months ago (2016-06-24 17:16:33 UTC) #12
Brian Osman
Assuming that the tests in Color4fTest just weren't needed? https://codereview.chromium.org/2097003003/diff/40001/src/core/SkColor.cpp File src/core/SkColor.cpp (right): https://codereview.chromium.org/2097003003/diff/40001/src/core/SkColor.cpp#newcode167 src/core/SkColor.cpp:167: ...
4 years, 6 months ago (2016-06-24 17:29:07 UTC) #13
reed1
https://codereview.chromium.org/2097003003/diff/40001/src/core/SkColor.cpp File src/core/SkColor.cpp (right): https://codereview.chromium.org/2097003003/diff/40001/src/core/SkColor.cpp#newcode167 src/core/SkColor.cpp:167: Sk4f value = SkNx_shuffle<2, 1, 0, 3>(Sk4f::Load(this->vec())); On 2016/06/24 ...
4 years, 6 months ago (2016-06-24 18:54:11 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097003003/60001
4 years, 6 months ago (2016-06-24 18:54:20 UTC) #16
Brian Osman
lgtm
4 years, 6 months ago (2016-06-24 18:55:01 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 19:15:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097003003/60001
4 years, 6 months ago (2016-06-25 01:13:16 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-25 01:14:12 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/a84d6606f5f53b8e1a42d55676e4f1ea47be5575

Powered by Google App Engine
This is Rietveld 408576698