Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Issue 2096853002: [ash-md] Adds UMA depth count for Overview mode (Closed)

Created:
4 years, 6 months ago by varkha
Modified:
4 years, 5 months ago
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Adds UMA depth count for Overview mode Adds Ash.WindowSelector.SelectionDepth UMA histogram that records how often users select a window that is N-th in MRU order. Selecting a window that is already currently active (top in MRU order) records 1. BUG=621562 Committed: https://crrev.com/afe425d883e82562a3db9454fc2b5d5f09b8b003 Cr-Commit-Position: refs/heads/master@{#402304}

Patch Set 1 #

Total comments: 6

Patch Set 2 : [ash-md] Adds UMA depth count for Overview mode (1-based index) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M ash/common/wm/overview/window_selector.cc View 1 1 chunk +14 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096853002/1
4 years, 6 months ago (2016-06-23 21:15:05 UTC) #2
varkha
tdanderson@, can you please take a look? Alt+Tab to follow.
4 years, 6 months ago (2016-06-23 21:15:31 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 22:17:40 UTC) #6
tdanderson
A few comments below, otherwise LGTM https://codereview.chromium.org/2096853002/diff/1/ash/common/wm/overview/window_selector.cc File ash/common/wm/overview/window_selector.cc (right): https://codereview.chromium.org/2096853002/diff/1/ash/common/wm/overview/window_selector.cc#newcode1 ash/common/wm/overview/window_selector.cc:1: // Copyright 2013 ...
4 years, 6 months ago (2016-06-24 00:17:51 UTC) #7
varkha
+asvitkine@ for OWNERS in tools/metrics/histograms/. https://codereview.chromium.org/2096853002/diff/1/ash/common/wm/overview/window_selector.cc File ash/common/wm/overview/window_selector.cc (right): https://codereview.chromium.org/2096853002/diff/1/ash/common/wm/overview/window_selector.cc#newcode1 ash/common/wm/overview/window_selector.cc:1: // Copyright 2013 The ...
4 years, 6 months ago (2016-06-24 16:31:39 UTC) #9
varkha
+rkaplow@ for OWNERS in tools/metrics/histograms/.
4 years, 6 months ago (2016-06-24 17:11:24 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096853002/20001
4 years, 6 months ago (2016-06-24 18:29:01 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 19:44:17 UTC) #16
varkha
holte@, can you please take a look for tools/metrics/OWNERS? Thanks
4 years, 6 months ago (2016-06-24 23:10:44 UTC) #18
varkha
+isherman@ for OWNERS just in case.
4 years, 5 months ago (2016-06-27 17:01:17 UTC) #20
rkaplow
lgtm
4 years, 5 months ago (2016-06-27 20:00:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096853002/20001
4 years, 5 months ago (2016-06-27 20:26:27 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 21:54:59 UTC) #27
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:57:29 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/afe425d883e82562a3db9454fc2b5d5f09b8b003
Cr-Commit-Position: refs/heads/master@{#402304}

Powered by Google App Engine
This is Rietveld 408576698