|
|
Description[ash-md] Adds UMA depth count for Overview mode
Adds Ash.WindowSelector.SelectionDepth UMA histogram that records how
often users select a window that is N-th in MRU order. Selecting a
window that is already currently active (top in MRU order) records 1.
BUG=621562
Committed: https://crrev.com/afe425d883e82562a3db9454fc2b5d5f09b8b003
Cr-Commit-Position: refs/heads/master@{#402304}
Patch Set 1 #
Total comments: 6
Patch Set 2 : [ash-md] Adds UMA depth count for Overview mode (1-based index) #
Messages
Total messages: 29 (15 generated)
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2096853002/1
varkha@chromium.org changed reviewers: + tdanderson@chromium.org
tdanderson@, can you please take a look? Alt+Tab to follow.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
A few comments below, otherwise LGTM https://codereview.chromium.org/2096853002/diff/1/ash/common/wm/overview/wind... File ash/common/wm/overview/window_selector.cc (right): https://codereview.chromium.org/2096853002/diff/1/ash/common/wm/overview/wind... ash/common/wm/overview/window_selector.cc:1: // Copyright 2013 The Chromium Authors. All rights reserved. Please include a CL description (and cite the histogram name in the description). https://codereview.chromium.org/2096853002/diff/1/ash/common/wm/overview/wind... ash/common/wm/overview/window_selector.cc:458: // Record UMA_WINDOW_OVERVIEW_ACTIVE_WINDOW_CHANGED if the user is selecting Move this comment above line 464 or 465. https://codereview.chromium.org/2096853002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2096853002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:1617: + at the moment when an item is selected. Suggested rewording for clarity, something like: "When a window is selected in overview mode, records that window's position in the global MRU ordering. 1 represents the most-recently used window, 2 represents the next most-recently used window, and so on."
Description was changed from ========== [ash-md] Adds UMA depth count for Overview mode BUG=621562 ========== to ========== [ash-md] Adds UMA depth count for Overview mode Adds Ash.WindowSelector.SelectionDepth UMA histogram that records how often users select a window that is N-th in MRU order. Selecting a window that is already currently active (top in MRU order) records 1. BUG=621562 ==========
+asvitkine@ for OWNERS in tools/metrics/histograms/. https://codereview.chromium.org/2096853002/diff/1/ash/common/wm/overview/wind... File ash/common/wm/overview/window_selector.cc (right): https://codereview.chromium.org/2096853002/diff/1/ash/common/wm/overview/wind... ash/common/wm/overview/window_selector.cc:1: // Copyright 2013 The Chromium Authors. All rights reserved. On 2016/06/24 00:17:50, tdanderson wrote: > Please include a CL description (and cite the histogram name in the > description). Done. https://codereview.chromium.org/2096853002/diff/1/ash/common/wm/overview/wind... ash/common/wm/overview/window_selector.cc:458: // Record UMA_WINDOW_OVERVIEW_ACTIVE_WINDOW_CHANGED if the user is selecting On 2016/06/24 00:17:50, tdanderson wrote: > Move this comment above line 464 or 465. Done. https://codereview.chromium.org/2096853002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2096853002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:1617: + at the moment when an item is selected. On 2016/06/24 00:17:51, tdanderson wrote: > Suggested rewording for clarity, something like: "When a window is selected in > overview mode, records that window's position in the global MRU ordering. 1 > represents the most-recently used window, 2 represents the next most-recently > used window, and so on." Done.
varkha@chromium.org changed reviewers: + rkaplow@chromium.org
+rkaplow@ for OWNERS in tools/metrics/histograms/.
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [ash-md] Adds UMA depth count for Overview mode Adds Ash.WindowSelector.SelectionDepth UMA histogram that records how often users select a window that is N-th in MRU order. Selecting a window that is already currently active (top in MRU order) records 1. BUG=621562 ========== to ========== [ash-md] Adds UMA depth count for Overview mode Adds Ash.WindowSelector.SelectionDepth UMA histogram that records how often users select a window that is N-th in MRU order. Selecting a window that is already currently active (top in MRU order) records 1. BUG=621562 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
varkha@chromium.org changed reviewers: + holte@chromium.org - rkaplow@chromium.org
holte@, can you please take a look for tools/metrics/OWNERS? Thanks
varkha@chromium.org changed reviewers: + isherman@chromium.org
+isherman@ for OWNERS just in case.
rkaplow@chromium.org changed reviewers: + rkaplow@chromium.org
lgtm
The CQ bit was checked by varkha@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tdanderson@chromium.org Link to the patchset: https://codereview.chromium.org/2096853002/#ps20001 (title: "[ash-md] Adds UMA depth count for Overview mode (1-based index)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [ash-md] Adds UMA depth count for Overview mode Adds Ash.WindowSelector.SelectionDepth UMA histogram that records how often users select a window that is N-th in MRU order. Selecting a window that is already currently active (top in MRU order) records 1. BUG=621562 ========== to ========== [ash-md] Adds UMA depth count for Overview mode Adds Ash.WindowSelector.SelectionDepth UMA histogram that records how often users select a window that is N-th in MRU order. Selecting a window that is already currently active (top in MRU order) records 1. BUG=621562 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [ash-md] Adds UMA depth count for Overview mode Adds Ash.WindowSelector.SelectionDepth UMA histogram that records how often users select a window that is N-th in MRU order. Selecting a window that is already currently active (top in MRU order) records 1. BUG=621562 ========== to ========== [ash-md] Adds UMA depth count for Overview mode Adds Ash.WindowSelector.SelectionDepth UMA histogram that records how often users select a window that is N-th in MRU order. Selecting a window that is already currently active (top in MRU order) records 1. BUG=621562 Committed: https://crrev.com/afe425d883e82562a3db9454fc2b5d5f09b8b003 Cr-Commit-Position: refs/heads/master@{#402304} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/afe425d883e82562a3db9454fc2b5d5f09b8b003 Cr-Commit-Position: refs/heads/master@{#402304} |