Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2096633002: Adds scroll position/scale emulation to DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Emulator using GC, moved to FrameHost, addressed other comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 2c3e9a0aae1cef9784986fde5cf36ff1727e135d..d251641b906c7deabd40ab56efb5dc04088148bd 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -69,6 +69,7 @@
namespace blink {
+class CompositorMutatorImpl;
class DataObject;
class DevToolsEmulator;
class Frame;
@@ -87,7 +88,6 @@ class WebLayerTreeView;
class WebLocalFrame;
class WebLocalFrameImpl;
class WebImage;
-class CompositorMutatorImpl;
class WebPagePopupImpl;
class WebPlugin;
class WebRemoteFrame;
@@ -530,6 +530,10 @@ private:
void setPageScaleFactorAndLocation(float, const FloatPoint&);
void propagateZoomFactorToLocalFrameRoots(Frame*, float);
+ // Override the page scale and scroll positions of main frame and visual viewport.
+ void setScrollAndScaleOverride(const WebDeviceEmulationParams&);
+ void clearScrollAndScaleOverride();
+
void scrollAndRescaleViewports(float scaleFactor, const IntPoint& mainFrameOrigin, const FloatPoint& visualViewportOrigin);
float maximumLegiblePageScale() const;

Powered by Google App Engine
This is Rietveld 408576698