third_party/WebKit/Source/web/tests/WebViewTest.cpp - Issue 2096633002: Adds scroll position/scale emulation to DevTools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2096633002: Adds scroll position/scale emulation to DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Emulator using GC, moved to FrameHost, addressed other comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

index a32e4562bcd64f4aa8be19556a92a42d1114d5fa..963379d42ede7a0d42f4a1526c22b5cc9aeda07d 100644

--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp

@@ -1076,7 +1076,7 @@ TEST_F(WebViewTest, ExitingDeviceEmulationResetsPageScale)

float pageScaleExpected = webViewImpl->pageScaleFactor();

WebDeviceEmulationParams params;

- params.screenPosition = WebDeviceEmulationParams::Desktop;

+ params.screenPosition = WebDeviceEmulationParams::Mobile;

bokan 2016/07/06 14:26:31 Why did this have to change?

Eric Seckler 2016/07/11 10:38:44 Reverted.

params.deviceScaleFactor = 0;

params.fitToView = false;

params.offset = WebFloatPoint();