Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dana's nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index 228e9a02349e4614528d46a1c454e7f57062ba34..93b76fa28b2b8e2f18a1a61f97e3c175df169271 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -148,9 +148,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
BrowserAccessibilityDelegate* delegate, bool for_root_frame) override;
bool LockMouse() override;
void UnlockMouse() override;
- void OnSwapCompositorFrame(
- uint32_t output_surface_id,
- std::unique_ptr<cc::CompositorFrame> frame) override;
+ void OnSwapCompositorFrame(uint32_t output_surface_id,
+ cc::CompositorFrame frame) override;
void ClearCompositorFrame() override;
void DidOverscroll(const DidOverscrollParams& params) override;
void DidStopFlinging() override;
@@ -247,8 +246,7 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
void OnShowingPastePopup(const gfx::PointF& point);
void OnShowUnhandledTapUIIfNeeded(int x_dip, int y_dip);
- void SynchronousFrameMetadata(
- const cc::CompositorFrameMetadata& frame_metadata);
+ void SynchronousFrameMetadata(cc::CompositorFrameMetadata frame_metadata);
void SetOverlayVideoMode(bool enabled);
@@ -265,9 +263,9 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
void DestroyDelegatedContent();
void CheckOutputSurfaceChanged(uint32_t output_surface_id);
- void SubmitCompositorFrame(std::unique_ptr<cc::CompositorFrame> frame_data);
+ void SubmitCompositorFrame(cc::CompositorFrame frame_data);
void SwapDelegatedFrame(uint32_t output_surface_id,
- std::unique_ptr<cc::CompositorFrame> frame_data);
+ cc::CompositorFrame frame_data);
void SendDelegatedFrameAck(uint32_t output_surface_id);
void SendReturnedDelegatedResources(uint32_t output_surface_id);
@@ -304,11 +302,10 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
// Drop any incoming frames from the renderer when there are locks on the
// current frame.
- void RetainFrame(uint32_t output_surface_id,
- std::unique_ptr<cc::CompositorFrame> frame);
+ void RetainFrame(uint32_t output_surface_id, cc::CompositorFrame frame);
void InternalSwapCompositorFrame(uint32_t output_surface_id,
- std::unique_ptr<cc::CompositorFrame> frame);
+ cc::CompositorFrame frame);
void OnLostResources();
enum VSyncRequestType {
@@ -392,11 +389,10 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
bool observing_root_window_;
struct LastFrameInfo {
- LastFrameInfo(uint32_t output_id,
- std::unique_ptr<cc::CompositorFrame> output_frame);
+ LastFrameInfo(uint32_t output_id, cc::CompositorFrame output_frame);
~LastFrameInfo();
uint32_t output_surface_id;
- std::unique_ptr<cc::CompositorFrame> frame;
+ cc::CompositorFrame frame;
};
std::unique_ptr<LastFrameInfo> last_frame_info_;

Powered by Google App Engine
This is Rietveld 408576698