Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dana's nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 7a1ee03f63afe170922169e10de1a5eae78dcea1..f2f8ace175bbe0b6f985d2273aee64cc0b7bcd27 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1535,20 +1535,19 @@ bool RenderWidgetHostImpl::OnSwapCompositorFrame(
ViewHostMsg_SwapCompositorFrame::Param param;
if (!ViewHostMsg_SwapCompositorFrame::Read(&message, &param))
return false;
- std::unique_ptr<cc::CompositorFrame> frame(new cc::CompositorFrame);
+ cc::CompositorFrame frame(std::move(std::get<1>(param)));
uint32_t output_surface_id = std::get<0>(param);
- std::get<1>(param).AssignTo(frame.get());
std::vector<IPC::Message> messages_to_deliver_with_frame;
messages_to_deliver_with_frame.swap(std::get<2>(param));
- if (!ui::LatencyInfo::Verify(frame->metadata.latency_info,
+ if (!ui::LatencyInfo::Verify(frame.metadata.latency_info,
"RenderWidgetHostImpl::OnSwapCompositorFrame")) {
- std::vector<ui::LatencyInfo>().swap(frame->metadata.latency_info);
+ std::vector<ui::LatencyInfo>().swap(frame.metadata.latency_info);
}
- latency_tracker_.OnSwapCompositorFrame(&frame->metadata.latency_info);
+ latency_tracker_.OnSwapCompositorFrame(&frame.metadata.latency_info);
- bool is_mobile_optimized = IsMobileOptimizedFrame(frame->metadata);
+ bool is_mobile_optimized = IsMobileOptimizedFrame(frame.metadata);
input_router_->NotifySiteIsMobileOptimized(is_mobile_optimized);
if (touch_emulator_)
touch_emulator_->SetDoubleTapSupportForPageEnabled(!is_mobile_optimized);
@@ -1558,13 +1557,12 @@ bool RenderWidgetHostImpl::OnSwapCompositorFrame(
view_->DidReceiveRendererFrame();
} else {
cc::CompositorFrameAck ack;
- if (frame->gl_frame_data) {
- ack.gl_frame_data = std::move(frame->gl_frame_data);
+ if (frame.gl_frame_data) {
+ ack.gl_frame_data = std::move(frame.gl_frame_data);
ack.gl_frame_data->sync_token.Clear();
- } else if (frame->delegated_frame_data) {
+ } else if (frame.delegated_frame_data) {
cc::TransferableResource::ReturnResources(
- frame->delegated_frame_data->resource_list,
- &ack.resources);
+ frame.delegated_frame_data->resource_list, &ack.resources);
}
SendSwapCompositorFrameAck(routing_id_, output_surface_id,
process_->GetID(), ack);
« no previous file with comments | « content/browser/renderer_host/delegated_frame_host.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698