content/browser/devtools/devtools_frame_trace_recorder.cc - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_frame_trace_recorder.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/devtools_frame_trace_recorder.cc

diff --git a/content/browser/devtools/devtools_frame_trace_recorder.cc b/content/browser/devtools/devtools_frame_trace_recorder.cc

index 8d4696fcc533b803bb0eea1fa3e835c0ce77b2cb..67cb09c074c9a6b1f57955ba331b4a54eeff5251 100644

--- a/content/browser/devtools/devtools_frame_trace_recorder.cc

+++ b/content/browser/devtools/devtools_frame_trace_recorder.cc

@@ -142,7 +142,8 @@ void DevToolsFrameTraceRecorder::OnSynchronousSwapCompositorFrame(

TRACE_EVENT_IS_NEW_TRACE(&is_new_trace);

if (!is_new_trace && last_metadata_)

CaptureFrame(host, *last_metadata_);

- last_metadata_.reset(new cc::CompositorFrameMetadata(frame_metadata));

+ last_metadata_.reset(new cc::CompositorFrameMetadata);

+ *last_metadata_ = frame_metadata.Clone();

}

} // namespace content