content/browser/compositor/software_browser_compositor_output_surface_unittest.cc - Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dana's nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/software_browser_compositor_output_surface.cc ('k') | content/browser/devtools/devtools_frame_trace_recorder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

diff --git a/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc b/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

index a3aab5d43acd5452d3c8e992eb36de5e20cd9a3c..8a6fd7dcebd5df2791f268e33fd6325ac058013a 100644

--- a/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

+++ b/content/browser/compositor/software_browser_compositor_output_surface_unittest.cc

@@ -119,7 +119,7 @@ TEST_F(SoftwareBrowserCompositorOutputSurfaceTest, NoVSyncProvider) {

CHECK(output_surface_->BindToClient(&output_surface_client));

cc::CompositorFrame frame;

- output_surface_->SwapBuffers(&frame);

+ output_surface_->SwapBuffers(std::move(frame));

EXPECT_EQ(1, output_surface_client.swap_count());

EXPECT_EQ(NULL, output_surface_->software_device()->GetVSyncProvider());

@@ -137,7 +137,7 @@ TEST_F(SoftwareBrowserCompositorOutputSurfaceTest, VSyncProviderUpdates) {

EXPECT_EQ(0, vsync_provider->call_count());

cc::CompositorFrame frame;

- output_surface_->SwapBuffers(&frame);

+ output_surface_->SwapBuffers(std::move(frame));

EXPECT_EQ(1, output_surface_client.swap_count());

EXPECT_EQ(1, vsync_provider->call_count());