Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: cc/output/gl_renderer_unittest.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dana's nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/output_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer_unittest.cc
diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc
index be83075db3ae7f43a3bcf523ff9ebd8628c98d88..a72f2dc4d49aa7774df4f75dc0a19e2220e6023b 100644
--- a/cc/output/gl_renderer_unittest.cc
+++ b/cc/output/gl_renderer_unittest.cc
@@ -1780,7 +1780,8 @@ class MockOutputSurface : public OutputSurface {
void(const gfx::Size& size, float scale_factor, bool has_alpha));
MOCK_METHOD0(BindFramebuffer, void());
MOCK_METHOD0(GetFramebufferCopyTextureFormat, GLenum());
- MOCK_METHOD1(SwapBuffers, void(CompositorFrame* frame));
+ MOCK_METHOD1(SwapBuffers_, void(CompositorFrame& frame));
+ void SwapBuffers(CompositorFrame frame) override { SwapBuffers_(frame); }
};
class MockOutputSurfaceTest : public GLRendererTest {
@@ -1849,7 +1850,7 @@ TEST_F(MockOutputSurfaceTest, DrawFrameAndSwap) {
gfx::Rect device_viewport_rect(1, 1);
DrawFrame(1.f, device_viewport_rect, true);
- EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1);
+ EXPECT_CALL(output_surface_, SwapBuffers_(_)).Times(1);
renderer_->SwapBuffers(CompositorFrameMetadata());
}
@@ -1857,7 +1858,7 @@ TEST_F(MockOutputSurfaceTest, DrawOpaqueFrameAndSwap) {
gfx::Rect device_viewport_rect(1, 1);
DrawFrame(1.f, device_viewport_rect, false);
- EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1);
+ EXPECT_CALL(output_surface_, SwapBuffers_(_)).Times(1);
renderer_->SwapBuffers(CompositorFrameMetadata());
}
@@ -1865,23 +1866,23 @@ TEST_F(MockOutputSurfaceTest, DrawFrameAndResizeAndSwap) {
gfx::Rect device_viewport_rect(1, 1);
DrawFrame(1.f, device_viewport_rect, true);
- EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1);
+ EXPECT_CALL(output_surface_, SwapBuffers_(_)).Times(1);
renderer_->SwapBuffers(CompositorFrameMetadata());
device_viewport_rect = gfx::Rect(2, 2);
DrawFrame(2.f, device_viewport_rect, true);
- EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1);
+ EXPECT_CALL(output_surface_, SwapBuffers_(_)).Times(1);
renderer_->SwapBuffers(CompositorFrameMetadata());
DrawFrame(2.f, device_viewport_rect, true);
- EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1);
+ EXPECT_CALL(output_surface_, SwapBuffers_(_)).Times(1);
renderer_->SwapBuffers(CompositorFrameMetadata());
device_viewport_rect = gfx::Rect(1, 1);
DrawFrame(1.f, device_viewport_rect, true);
- EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1);
+ EXPECT_CALL(output_surface_, SwapBuffers_(_)).Times(1);
renderer_->SwapBuffers(CompositorFrameMetadata());
}
« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/output/output_surface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698