Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6176)

Unified Diff: cc/output/gl_renderer.cc

Issue 2096493002: Make cc::CompositorFrames movable [Part 1 of 2] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dana's nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer.h ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index 7b5cb684a73854dcb26937f41bf2d9b7ce568a34..1f52d925d76ef55829ae7656d813c6c5e548eef3 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -2709,7 +2709,7 @@ void GLRenderer::Finish() {
gl_->Finish();
}
-void GLRenderer::SwapBuffers(const CompositorFrameMetadata& metadata) {
+void GLRenderer::SwapBuffers(CompositorFrameMetadata metadata) {
DCHECK(!is_backbuffer_discarded_);
TRACE_EVENT0("cc,benchmark", "GLRenderer::SwapBuffers");
@@ -2718,7 +2718,7 @@ void GLRenderer::SwapBuffers(const CompositorFrameMetadata& metadata) {
gfx::Size surface_size = output_surface_->SurfaceSize();
CompositorFrame compositor_frame;
- compositor_frame.metadata = metadata;
+ compositor_frame.metadata = std::move(metadata);
compositor_frame.gl_frame_data = base::WrapUnique(new GLFrameData);
compositor_frame.gl_frame_data->size = surface_size;
if (capabilities_.using_partial_swap) {
@@ -2752,7 +2752,7 @@ void GLRenderer::SwapBuffers(const CompositorFrameMetadata& metadata) {
swapping_overlay_resources_.pop_front();
}
- output_surface_->SwapBuffers(&compositor_frame);
+ output_surface_->SwapBuffers(std::move(compositor_frame));
swap_buffer_rect_ = gfx::Rect();
}
« no previous file with comments | « cc/output/gl_renderer.h ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698