Make cc::CompositorFrames movable [Part 1 of 2]

cc/output/compositor_frame.h

Index: cc/output/compositor_frame.h
diff --git a/cc/output/compositor_frame.h b/cc/output/compositor_frame.h
index e5e0c660f6faeb3930d5f3339bb686b380e605bd..3a47f90ef9c569102f6f58df1e658650745721ab 100644
--- a/cc/output/compositor_frame.h
+++ b/cc/output/compositor_frame.h
@@ -20,14 +20,16 @@ namespace cc {
 // TODO(fsamuel): Write more here.
 class CC_EXPORT CompositorFrame {
  public:
-  CompositorFrame();
   ~CompositorFrame();
 
+  static std::unique_ptr<CompositorFrame> Create();

[danakj, 2016/06/23 20:34:41]

Please just leave the constructor public and drop the Create().

+
   CompositorFrameMetadata metadata;
   std::unique_ptr<DelegatedFrameData> delegated_frame_data;
   std::unique_ptr<GLFrameData> gl_frame_data;
 
-  void AssignTo(CompositorFrame* target);
+ protected:

[piman, 2016/06/23 19:30:32]

How about private? I don't think we want to have classes derive from this.

[danakj, 2016/06/23 20:34:41]

I'd rather just not have a Create() method at all.

[Fady Samuel, 2016/06/23 23:41:00]

Done.

+  CompositorFrame();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CompositorFrame);