Make cc::CompositorFrames movable [Part 1 of 2]

cc/output/compositor_frame.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_OUTPUT_COMPOSITOR_FRAME_H_
 #define CC_OUTPUT_COMPOSITOR_FRAME_H_
 
 #include <memory>
 
 #include "base/macros.h"
 #include "cc/base/cc_export.h"
 #include "cc/output/compositor_frame_metadata.h"
 #include "cc/output/delegated_frame_data.h"
 #include "cc/output/gl_frame_data.h"
 
 namespace cc {
 
 // A CompositorFrame struct contains the complete output of a compositor meant
 // for display.
 // TODO(fsamuel): Write more here.
 class CC_EXPORT CompositorFrame {
  public:
-  CompositorFrame();
   ~CompositorFrame();
 
+  static std::unique_ptr<CompositorFrame> Create();

[danakj, 2016/06/23 20:34:41]

Please just leave the constructor public and drop the Create().

+
   CompositorFrameMetadata metadata;
   std::unique_ptr<DelegatedFrameData> delegated_frame_data;
   std::unique_ptr<GLFrameData> gl_frame_data;
 
-  void AssignTo(CompositorFrame* target);
+ protected:

[piman, 2016/06/23 19:30:32]

How about private? I don't think we want to have classes derive from this.

[danakj, 2016/06/23 20:34:41]

I'd rather just not have a Create() method at all.

[Fady Samuel, 2016/06/23 23:41:00]

Done.

+  CompositorFrame();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CompositorFrame);
 };
 
 }  // namespace cc
 
 #endif  // CC_OUTPUT_COMPOSITOR_FRAME_H_