Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2096133002: [Typed OM] Add support for properties which take numbers in CSSProperties.in (Closed)

Created:
4 years, 6 months ago by meade_UTC10
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Typed OM] Add support for properties which take numbers in CSSProperties.in BUG=545318

Patch Set 1 #

Patch Set 2 : Update StyleValueFactory, add test #

Patch Set 3 : Adjust StyleValueFactory to more correctly process list values #

Patch Set 4 : Update LayoutTests #

Patch Set 5 : Rearrange set method. Still crashes for animation-iteration-count #

Patch Set 6 : Update stuff and add more tests for append #

Patch Set 7 : Add expectations for failing tests that are missing some parts of imple #

Patch Set 8 : sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -46 lines) Patch
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_append.html View 1 2 3 4 5 6 3 chunks +35 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_append-expected.txt View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll.html View 1 2 3 4 5 6 7 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll-expected.txt View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet.html View 1 2 3 4 5 6 7 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet-expected.txt View 1 2 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html View 1 2 3 4 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers-expected.txt View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 2 3 4 5 6 7 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 1 2 3 4 5 3 chunks +41 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp View 1 2 3 4 5 2 chunks +46 lines, -16 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
meade_UTC10
3 years, 7 months ago (2017-05-25 07:11:06 UTC) #1
Description was changed from

==========
[Typed OM] Add support for properties which take numbers in CSSProperties.in

BUG=545318
==========

to

==========
[Typed OM] Add support for properties which take numbers in CSSProperties.in

BUG=545318
==========

Powered by Google App Engine
This is Rietveld 408576698