content/browser/download/download_item_impl.h - Issue 209613002: Download shelf autohides on showing in shell, just same as regular open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.h

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move the 'user acted' flag into DownloadItemModelData and get rid of SetOpened/SetShown in Download… Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/download/download_item_controller.mm ('K') | « chrome/browser/ui/views/download/download_shelf_view.cc ('k') | content/browser/download/download_item_impl.cc » ('j') | content/public/test/mock_download_item.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_item_impl.h

diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h

index e66026285ac5954da1728c86a426dd0fa4717d71..af969dbfd1cb0624e0babf5c4cd77ce221a19547 100644

--- a/content/browser/download/download_item_impl.h

+++ b/content/browser/download/download_item_impl.h

@@ -6,6 +6,7 @@

#define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_

#include <string>

+#include <vector>

#include "base/basictypes.h"

#include "base/callback_forward.h"

@@ -153,7 +154,6 @@ class CONTENT_EXPORT DownloadItemImpl

virtual void OnContentCheckCompleted(DownloadDangerType danger_type) OVERRIDE;

virtual void SetOpenWhenComplete(bool open) OVERRIDE;

virtual void SetIsTemporary(bool temporary) OVERRIDE;

- virtual void SetOpened(bool opened) OVERRIDE;

virtual void SetDisplayName(const base::FilePath& name) OVERRIDE;

virtual std::string DebugString(bool verbose) const OVERRIDE;