Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Side by Side Diff: content/browser/download/download_item_impl.h

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move the 'user acted' flag into DownloadItemModelData and get rid of SetOpened/SetShown in Download… Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_ 5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_ 6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector>
9 10
10 #include "base/basictypes.h" 11 #include "base/basictypes.h"
11 #include "base/callback_forward.h" 12 #include "base/callback_forward.h"
12 #include "base/files/file_path.h" 13 #include "base/files/file_path.h"
13 #include "base/memory/scoped_ptr.h" 14 #include "base/memory/scoped_ptr.h"
14 #include "base/memory/weak_ptr.h" 15 #include "base/memory/weak_ptr.h"
15 #include "base/observer_list.h" 16 #include "base/observer_list.h"
16 #include "base/time/time.h" 17 #include "base/time/time.h"
17 #include "base/timer/timer.h" 18 #include "base/timer/timer.h"
18 #include "content/browser/download/download_net_log_parameters.h" 19 #include "content/browser/download/download_net_log_parameters.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 virtual bool CanOpenDownload() OVERRIDE; 147 virtual bool CanOpenDownload() OVERRIDE;
147 virtual bool ShouldOpenFileBasedOnExtension() OVERRIDE; 148 virtual bool ShouldOpenFileBasedOnExtension() OVERRIDE;
148 virtual bool GetOpenWhenComplete() const OVERRIDE; 149 virtual bool GetOpenWhenComplete() const OVERRIDE;
149 virtual bool GetAutoOpened() OVERRIDE; 150 virtual bool GetAutoOpened() OVERRIDE;
150 virtual bool GetOpened() const OVERRIDE; 151 virtual bool GetOpened() const OVERRIDE;
151 virtual BrowserContext* GetBrowserContext() const OVERRIDE; 152 virtual BrowserContext* GetBrowserContext() const OVERRIDE;
152 virtual WebContents* GetWebContents() const OVERRIDE; 153 virtual WebContents* GetWebContents() const OVERRIDE;
153 virtual void OnContentCheckCompleted(DownloadDangerType danger_type) OVERRIDE; 154 virtual void OnContentCheckCompleted(DownloadDangerType danger_type) OVERRIDE;
154 virtual void SetOpenWhenComplete(bool open) OVERRIDE; 155 virtual void SetOpenWhenComplete(bool open) OVERRIDE;
155 virtual void SetIsTemporary(bool temporary) OVERRIDE; 156 virtual void SetIsTemporary(bool temporary) OVERRIDE;
156 virtual void SetOpened(bool opened) OVERRIDE;
157 virtual void SetDisplayName(const base::FilePath& name) OVERRIDE; 157 virtual void SetDisplayName(const base::FilePath& name) OVERRIDE;
158 virtual std::string DebugString(bool verbose) const OVERRIDE; 158 virtual std::string DebugString(bool verbose) const OVERRIDE;
159 159
160 // All remaining public interfaces virtual to allow for DownloadItemImpl 160 // All remaining public interfaces virtual to allow for DownloadItemImpl
161 // mocks. 161 // mocks.
162 162
163 // Determines the resume mode for an interrupted download. Requires 163 // Determines the resume mode for an interrupted download. Requires
164 // last_reason_ to be set, but doesn't require the download to be in 164 // last_reason_ to be set, but doesn't require the download to be in
165 // INTERRUPTED state. 165 // INTERRUPTED state.
166 virtual ResumeMode GetResumeMode() const; 166 virtual ResumeMode GetResumeMode() const;
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
551 const net::BoundNetLog bound_net_log_; 551 const net::BoundNetLog bound_net_log_;
552 552
553 base::WeakPtrFactory<DownloadItemImpl> weak_ptr_factory_; 553 base::WeakPtrFactory<DownloadItemImpl> weak_ptr_factory_;
554 554
555 DISALLOW_COPY_AND_ASSIGN(DownloadItemImpl); 555 DISALLOW_COPY_AND_ASSIGN(DownloadItemImpl);
556 }; 556 };
557 557
558 } // namespace content 558 } // namespace content
559 559
560 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_ 560 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698