 Chromium Code Reviews
 Chromium Code Reviews Issue 209613002:
  Download shelf autohides on showing in shell, just same as regular open 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 209613002:
  Download shelf autohides on showing in shell, just same as regular open 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: content/public/browser/download_item.h | 
| diff --git a/content/public/browser/download_item.h b/content/public/browser/download_item.h | 
| index 1e66f8b8a0d06ff62cf766820ff1e988dd25b0be..c78e1dce0ab1f47aab88bc074f2b0e0e3d226ea6 100644 | 
| --- a/content/public/browser/download_item.h | 
| +++ b/content/public/browser/download_item.h | 
| @@ -89,6 +89,7 @@ class CONTENT_EXPORT DownloadItem : public base::SupportsUserData { | 
| virtual void OnDownloadUpdated(DownloadItem* download) {} | 
| virtual void OnDownloadOpened(DownloadItem* download) {} | 
| virtual void OnDownloadRemoved(DownloadItem* download) {} | 
| + virtual void OnDownloadShown(DownloadItem* download) {} | 
| // Called when the download is being destroyed. This happens after | 
| // every OnDownloadRemoved() as well as when the DownloadManager is going | 
| @@ -300,6 +301,9 @@ class CONTENT_EXPORT DownloadItem : public base::SupportsUserData { | 
| // Returns true if the download has been opened. | 
| virtual bool GetOpened() const = 0; | 
| + // Returns true if the download has been shown after it has been completed. | 
| + virtual bool GetShownWhenComplete() const = 0; | 
| + | 
| // Misc State accessors --------------------------------------------------- | 
| virtual BrowserContext* GetBrowserContext() const = 0; | 
| @@ -324,6 +328,9 @@ class CONTENT_EXPORT DownloadItem : public base::SupportsUserData { | 
| // Mark the download as having been opened (without actually opening it). | 
| virtual void SetOpened(bool opened) = 0; | 
| + // Mark the download as having been shown (without actually showing it). | 
| + virtual void SetShownWhenComplete(bool shown) = 0; | 
| 
asanka
2014/05/14 18:40:59
I'd like to get rid of both SetOpened() and SetSho
 
DukeXar
2014/06/06 15:07:14
Done.
 | 
| + | 
| // Set a display name for the download that will be independent of the target | 
| // filename. If |name| is not empty, then GetFileNameToReportUser() will | 
| // return |name|. Has no effect on the final target filename. |