Download shelf autohides on showing in shell, just same as regular open

content/public/browser/download_item.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Each download is represented by a DownloadItem, and all DownloadItems
 // are owned by the DownloadManager which maintains a global list of all
 // downloads. DownloadItems are created when a user initiates a download,
 // and exist for the duration of the browser life time.
 //
 // Download observers:
@@ skipping 71 matching lines @@
 
   static const char kEmptyFileHash[];
 
   // Interface that observers of a particular download must implement in order
   // to receive updates to the download's status.
   class CONTENT_EXPORT Observer {
    public:
     virtual void OnDownloadUpdated(DownloadItem* download) {}
     virtual void OnDownloadOpened(DownloadItem* download) {}
     virtual void OnDownloadRemoved(DownloadItem* download) {}
+    virtual void OnDownloadShown(DownloadItem* download) {}
 
     // Called when the download is being destroyed. This happens after
     // every OnDownloadRemoved() as well as when the DownloadManager is going
     // down.
     virtual void OnDownloadDestroyed(DownloadItem* download) {}
 
    protected:
     virtual ~Observer() {}
   };
 
@@ skipping 191 matching lines @@
 
   // Returns true if the download will be auto-opened when complete.
   virtual bool GetOpenWhenComplete() const = 0;
 
   // Returns true if the download has been auto-opened by the system.
   virtual bool GetAutoOpened() = 0;
 
   // Returns true if the download has been opened.
   virtual bool GetOpened() const = 0;
 
+  // Returns true if the download has been shown after it has been completed.
+  virtual bool GetShownWhenComplete() const = 0;
+
   //    Misc State accessors ---------------------------------------------------
 
   virtual BrowserContext* GetBrowserContext() const = 0;
   virtual WebContents* GetWebContents() const = 0;
 
   // External state transitions/setters ----------------------------------------
   // TODO(rdsmith): These should all be removed; the download item should
   // control its own state transitions.
 
   // Called if a check of the download contents was performed and the results of
   // the test are available. This should only be called after AllDataSaved() is
   // true.
   virtual void OnContentCheckCompleted(DownloadDangerType danger_type) = 0;
 
   // Mark the download to be auto-opened when completed.
   virtual void SetOpenWhenComplete(bool open) = 0;
 
   // Mark the download as temporary (not visible in persisted store or
   // SearchDownloads(), removed from main UI upon completion).
   virtual void SetIsTemporary(bool temporary) = 0;
 
   // Mark the download as having been opened (without actually opening it).
   virtual void SetOpened(bool opened) = 0;
 
+  // Mark the download as having been shown (without actually showing it).
+  virtual void SetShownWhenComplete(bool shown) = 0;

[asanka, 2014/05/14 18:40:59]

I'd like to get rid of both SetOpened() and SetShownWhenComplete(). Instead we
can opt to track the "acted on" state in DownloadItemModel. It might be that
once we have that bit, then both GetOpened()/GetShownWhenComplete() can also be
removed.

We'd still need the OnDownloadShown() notification since that would then be a
non-state-changing operation that's not detectable from examining the
DownloadItem.

[DukeXar, 2014/06/06 15:07:14]

Done.

+
   // Set a display name for the download that will be independent of the target
   // filename. If |name| is not empty, then GetFileNameToReportUser() will
   // return |name|. Has no effect on the final target filename.
   virtual void SetDisplayName(const base::FilePath& name) = 0;
 
   // Debug/testing -------------------------------------------------------------
   virtual std::string DebugString(bool verbose) const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DOWNLOAD_ITEM_H_