chrome/browser/ui/views/download/download_item_view.cc - Issue 209613002: Download shelf autohides on showing in shell, just same as regular open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_item_view.cc

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implement a separate callbacks flow for 'shown in shell' event to not mix with 'opened' Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/download/download_item_view.h ('k') | chrome/browser/ui/views/download/download_shelf_view.h » ('j') | chrome/browser/ui/views/download/download_shelf_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/download/download_item_view.cc

diff --git a/chrome/browser/ui/views/download/download_item_view.cc b/chrome/browser/ui/views/download/download_item_view.cc

index a1b609801d36eaadf0b9a1762e2ffdbc1d4f9943..2300286c417fe4addc0787b33268fd68ea5fe501 100644

--- a/chrome/browser/ui/views/download/download_item_view.cc

+++ b/chrome/browser/ui/views/download/download_item_view.cc

@@ -335,6 +335,10 @@ void DownloadItemView::OnDownloadOpened(DownloadItem* download) {

shelf_->OpenedDownload(this);

}

+void DownloadItemView::OnDownloadShown(DownloadItem* download) {

+ shelf_->ShownDownload(this);

// View overrides

// In dangerous mode we have to layout our buttons.