chrome/browser/ui/views/download/download_item_view.h - Issue 209613002: Download shelf autohides on showing in shell, just same as regular open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_item_view.h

Issue 209613002: Download shelf autohides on showing in shell, just same as regular open Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Implement a separate callbacks flow for 'shown in shell' event to not mix with 'opened' Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/all_download_item_notifier.cc ('k') | chrome/browser/ui/views/download/download_item_view.cc » ('j') | chrome/browser/ui/views/download/download_shelf_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/download/download_item_view.h

diff --git a/chrome/browser/ui/views/download/download_item_view.h b/chrome/browser/ui/views/download/download_item_view.h

index 0dffb2efc2b247cf4b6ffde5117367ed358a68ed..11ed70467d44793c32bece71dfbf5d4d424a60a8 100644

--- a/chrome/browser/ui/views/download/download_item_view.h

+++ b/chrome/browser/ui/views/download/download_item_view.h

@@ -73,6 +73,7 @@ class DownloadItemView : public views::ButtonListener,

virtual void OnDownloadUpdated(content::DownloadItem* download) OVERRIDE;

virtual void OnDownloadOpened(content::DownloadItem* download) OVERRIDE;

virtual void OnDownloadDestroyed(content::DownloadItem* download) OVERRIDE;

+ virtual void OnDownloadShown(content::DownloadItem* download) OVERRIDE;

// Overridden from views::View:

virtual void Layout() OVERRIDE;