Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: git_cl.py

Issue 2096123003: upload.py: honor explicit empty title (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/upload.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: git_cl.py
diff --git a/git_cl.py b/git_cl.py
index 7913e989d0345483b70b65e303a711adcf5365fd..17b8ffb315f43d440ef4ad35d23c2aea0204160e 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1898,7 +1898,7 @@ class _RietveldChangelistImpl(_ChangelistCodereviewBase):
upload_args.extend(['--email', options.email])
if self.GetIssue():
- if options.title:
+ if options.title is not None:
upload_args.extend(['--title', options.title])
if options.message:
upload_args.extend(['--message', options.message])
@@ -1906,7 +1906,7 @@ class _RietveldChangelistImpl(_ChangelistCodereviewBase):
print('This branch is associated with issue %s. '
'Adding patch to that issue.' % self.GetIssue())
else:
- if options.title:
+ if options.title is not None:
upload_args.extend(['--title', options.title])
message = (options.title or options.message or
CreateDescriptionFromLog(args))
« no previous file with comments | « no previous file | third_party/upload.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698