Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: third_party/upload.py

Issue 2096123003: upload.py: honor explicit empty title (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/upload.py
diff --git a/third_party/upload.py b/third_party/upload.py
index 68cf7fe18e86da0c12a25e48dc13ac2c02a6c8a6..dc145ef7b553e44d6f9829804c73922f61c51fc7 100755
--- a/third_party/upload.py
+++ b/third_party/upload.py
@@ -2440,6 +2440,7 @@ def RealMain(argv, data=None):
# Process --message, --title and --file.
message = options.message or ""
+ explicit_title = options.title is not None
title = options.title or ""
if options.file:
if options.message:
@@ -2448,7 +2449,7 @@ def RealMain(argv, data=None):
message = file.read()
file.close()
title = title or message.split('\n', 1)[0].strip()
- if not title:
+ if not title and not explicit_title:
if options.issue:
prompt = "Title describing this patch set"
else:
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698