Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 2096123003: upload.py: honor explicit empty title (Closed)

Created:
4 years, 6 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : upload.py: honor explicit empty title #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M git_cl.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/upload.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
nodir
PTAL
4 years, 6 months ago (2016-06-24 21:09:43 UTC) #2
pauljensen
I don't know much about this code so I don't think I'm qualified to review ...
4 years, 5 months ago (2016-06-27 11:24:37 UTC) #3
nodir
+vadimsh
4 years, 5 months ago (2016-06-27 17:51:30 UTC) #5
Vadim Sh.
lgtm
4 years, 5 months ago (2016-06-27 17:53:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096123003/40001
4 years, 5 months ago (2016-06-27 17:56:17 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 17:59:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/ca166003fb60b4...

Powered by Google App Engine
This is Rietveld 408576698