Move weave packet to common location b/t generator and receiver

components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.h"
 
 #ifdef OS_WIN
 #include <winsock2.h>
 #else
 #include <netinet/in.h>
 #endif
 
 #include <string.h>
 
 #include <algorithm>
 
 #include "base/logging.h"
 
+namespace proximity_auth {

[Kyle Horimoto, 2016/06/27 20:51:12]

Why is this moved? Same in the other unit test.

[jingxuy, 2016/06/27 22:21:33]

I saw that this is how the connection class does it currently. I think as long
as the namespace is anonymous, it achieves the same purpose whether it's inside
a namespace or within the global namespace. But if it's declared within
proxmity_auth, it has the benefit of accessing functions/types from that
namespace. I moved it here for the benefit of the typedefs will not need to go
through proximity_auth again.

[Kyle Horimoto, 2016/06/27 22:25:40]

Ah, good idea. Thanks for the explanation.

[jingxuy, 2016/06/27 22:49:08]

np

+
 namespace {
 
-typedef proximity_auth::BluetoothLowEnergyWeavePacketGenerator::Packet Packet;
+typedef BluetoothLowEnergyWeavePacket::ControlCommand ControlCommand;
+typedef BluetoothLowEnergyWeavePacket::Packet Packet;
+typedef BluetoothLowEnergyWeavePacket::PacketType PacketType;
+typedef BluetoothLowEnergyWeavePacket::ReasonForClose ReasonForClose;
 
 const uint16_t kMinSupportedWeaveVersion = 1;
 const uint16_t kMaxSupportedWeaveVersion = 1;
 const uint16_t kServerWeaveVersion = 1;
 const uint16_t kMinConnectionRequestSize = 7;
 const uint16_t kMinConnectionResponseSize = 5;
 const uint16_t kMinConnectionCloseSize = 3;
 const uint32_t kDefaultMaxPacketSize = 20;
 // Max packet size is 0, which means defer the decision to the server.
 const uint16_t kMaxSupportedPacketSize = 0;
 const uint8_t kMaxPacketCounter = 8;
 
 }  // namespace
 
-namespace proximity_auth {
-
 // static.
 BluetoothLowEnergyWeavePacketGenerator::Factory*
     BluetoothLowEnergyWeavePacketGenerator::Factory::factory_instance_ =
         nullptr;
 
 // static.
 std::unique_ptr<BluetoothLowEnergyWeavePacketGenerator>
 BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance() {
   if (factory_instance_ == nullptr) {
     factory_instance_ = new Factory();
@@ skipping 158 matching lines @@
 
 void BluetoothLowEnergyWeavePacketGenerator::SetDataLastBit(Packet* packet) {
   DCHECK(packet);
   DCHECK(!packet->empty());
 
   // Last bit is the bit 2 of the packet's first byte and set it to 1.
   packet->at(0) = packet->at(0) | (1 << 2);
 }
 
 }  // namespace proximity_auth