Move weave packet to common location b/t generator and receiver

components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.cc

Index: components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.cc
diff --git a/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.cc b/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.cc
index 576296ca3b6f5fc647ae84d882251d707c0e578a..942f312658d9815080e138825e7c21257b589347 100644
--- a/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.cc
+++ b/components/proximity_auth/ble/bluetooth_low_energy_weave_packet_generator.cc
@@ -16,9 +16,14 @@
 
 #include "base/logging.h"
 
+namespace proximity_auth {

[Kyle Horimoto, 2016/06/27 20:51:12]

Why is this moved? Same in the other unit test.

[jingxuy, 2016/06/27 22:21:33]

I saw that this is how the connection class does it currently. I think as long
as the namespace is anonymous, it achieves the same purpose whether it's inside
a namespace or within the global namespace. But if it's declared within
proxmity_auth, it has the benefit of accessing functions/types from that
namespace. I moved it here for the benefit of the typedefs will not need to go
through proximity_auth again.

[Kyle Horimoto, 2016/06/27 22:25:40]

Ah, good idea. Thanks for the explanation.

[jingxuy, 2016/06/27 22:49:08]

np

+
 namespace {
 
-typedef proximity_auth::BluetoothLowEnergyWeavePacketGenerator::Packet Packet;
+typedef BluetoothLowEnergyWeavePacket::ControlCommand ControlCommand;
+typedef BluetoothLowEnergyWeavePacket::Packet Packet;
+typedef BluetoothLowEnergyWeavePacket::PacketType PacketType;
+typedef BluetoothLowEnergyWeavePacket::ReasonForClose ReasonForClose;
 
 const uint16_t kMinSupportedWeaveVersion = 1;
 const uint16_t kMaxSupportedWeaveVersion = 1;
@@ -33,8 +38,6 @@ const uint8_t kMaxPacketCounter = 8;
 
 }  // namespace
 
-namespace proximity_auth {
-
 // static.
 BluetoothLowEnergyWeavePacketGenerator::Factory*
     BluetoothLowEnergyWeavePacketGenerator::Factory::factory_instance_ =