Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2096063002: [ash-md] Adds UMA items count and selection depth for Alt+Tab (Closed)

Created:
4 years, 6 months ago by varkha
Modified:
4 years, 5 months ago
Reviewers:
tdanderson, rkaplow
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Adds UMA items count and selection depth for Alt+Tab Adds Ash.WindowCycleController.Items UMA histogram that records how many windows are included in Alt+Tab enumeration. The count is captured when Alt+Tab is pressed. Adds Ash.WindowCycleController.SelectionDepth UMA histogram that records how often users finish Alt+Tab selection on a window that is N-th in MRU order. Selecting a window that is already currently active (top in MRU order) records 1. BUG=621562 Committed: https://crrev.com/a81779b51a943a37acf879c458d9c84fade53251 Cr-Commit-Position: refs/heads/master@{#402365}

Patch Set 1 : [ash-md] Adds UMA items count and selection depth for Alt+Tab (rebased) #

Total comments: 10

Patch Set 2 : [ash-md] Adds UMA items count and selection depth for Alt+Tab (comments) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M ash/wm/window_cycle_controller.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ash/wm/window_cycle_list.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +24 lines, -4 lines 0 comments Download

Messages

Total messages: 32 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096063002/1
4 years, 6 months ago (2016-06-24 18:54:54 UTC) #2
varkha
Can you please take a look? tdanderson@ for changes in ash/wm/. rkaplow@ for OWNERS in ...
4 years, 6 months ago (2016-06-24 18:56:22 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/26426) ios-device-gn on ...
4 years, 6 months ago (2016-06-24 18:57:32 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096063002/20001
4 years, 6 months ago (2016-06-24 18:59:45 UTC) #8
tdanderson
LGTM with the comments below https://codereview.chromium.org/2096063002/diff/20001/ash/wm/window_cycle_controller.cc File ash/wm/window_cycle_controller.cc (right): https://codereview.chromium.org/2096063002/diff/20001/ash/wm/window_cycle_controller.cc#newcode112 ash/wm/window_cycle_controller.cc:112: int depth = window_cycle_list_->current_index(); ...
4 years, 6 months ago (2016-06-24 19:25:57 UTC) #10
varkha
https://codereview.chromium.org/2096063002/diff/20001/ash/wm/window_cycle_controller.cc File ash/wm/window_cycle_controller.cc (right): https://codereview.chromium.org/2096063002/diff/20001/ash/wm/window_cycle_controller.cc#newcode112 ash/wm/window_cycle_controller.cc:112: int depth = window_cycle_list_->current_index(); On 2016/06/24 19:25:56, tdanderson wrote: ...
4 years, 6 months ago (2016-06-24 19:59:46 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096063002/40001
4 years, 6 months ago (2016-06-24 20:05:32 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 21:10:21 UTC) #15
varkha
holte@, can you please take a look for tools/metrics/OWNERS? Thanks!
4 years, 6 months ago (2016-06-24 23:11:12 UTC) #17
varkha
+isherman@ for OWNERS just in case.
4 years, 5 months ago (2016-06-27 17:00:47 UTC) #19
varkha
Back to rkaplow@ for owners. Thanks!
4 years, 5 months ago (2016-06-27 20:26:42 UTC) #21
rkaplow
lgtm
4 years, 5 months ago (2016-06-27 20:40:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096063002/40001
4 years, 5 months ago (2016-06-27 20:44:05 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/253221)
4 years, 5 months ago (2016-06-27 23:57:42 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2096063002/40001
4 years, 5 months ago (2016-06-28 00:02:23 UTC) #29
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-06-28 01:39:35 UTC) #30
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 01:41:26 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a81779b51a943a37acf879c458d9c84fade53251
Cr-Commit-Position: refs/heads/master@{#402365}

Powered by Google App Engine
This is Rietveld 408576698