Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2095923002:
[tools/perf] Add long running dual browser benchmark (Closed)
Description[tools/perf] Add long running dual browser benchmark
Add a new benchmark for measuring memory during prolonged usage of
alternating browsers.
Benchmark is same as memory.dual_browser_test, but the test is run for
60 iterations and the browser is *not* restarted between page set
repeats.
BUG=623015
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq
Committed: https://crrev.com/968d1c528ba5eb455244132fd2efbb5fa5c7fa27
Cr-Commit-Position: refs/heads/master@{#402215}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 20 (8 generated)
Description was changed from ========== [tools/perf] Add long running dual browser benchmark Add a new benchmark for measuring memory during prolonged usage of alternating browsers. Benchmark is same as memory.dual_browser_test, but the test is run for 60 iterations and the browser is *not* restarted between page set repeats. BUG=623015 ========== to ========== [tools/perf] Add long running dual browser benchmark Add a new benchmark for measuring memory during prolonged usage of alternating browsers. Benchmark is same as memory.dual_browser_test, but the test is run for 60 iterations and the browser is *not* restarted between page set repeats. BUG=623015 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
perezju@chromium.org changed reviewers: + nednguyen@google.com, primiano@chromium.org
https://codereview.chromium.org/2095923002/diff/1/tools/perf/benchmarks/memor... File tools/perf/benchmarks/memory_infra.py (right): https://codereview.chromium.org/2095923002/diff/1/tools/perf/benchmarks/memor... tools/perf/benchmarks/memory_infra.py:160: return False Note this method does not exist, yet. Will be added by https://codereview.chromium.org/2091103003/ However, there is no harm of landing this CL first. The method is just never called, and the current default behavior is the same as the one required by this benchmark.
LGTM
On 2016/06/24 13:15:02, Primiano Tucci wrote: > LGTM What is the cycle time of this?
On 2016/06/27 00:06:20, nednguyen wrote: > On 2016/06/24 13:15:02, Primiano Tucci wrote: > > LGTM > > What is the cycle time of this? looong in the order of ~ 5 hours. This is why the benchmark is disabled by default. The intention is to only run it on a dedicated internal bot, and replace the (also very long running) Memory Acceptance Test.
lgtm
The CQ bit was checked by perezju@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)
Description was changed from ========== [tools/perf] Add long running dual browser benchmark Add a new benchmark for measuring memory during prolonged usage of alternating browsers. Benchmark is same as memory.dual_browser_test, but the test is run for 60 iterations and the browser is *not* restarted between page set repeats. BUG=623015 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [tools/perf] Add long running dual browser benchmark Add a new benchmark for measuring memory during prolonged usage of alternating browsers. Benchmark is same as memory.dual_browser_test, but the test is run for 60 iterations and the browser is *not* restarted between page set repeats. BUG=623015 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq ==========
On 2016/06/27 17:31:18, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, > http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...) Removed unrelated CQ_TRY_BOT
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Add long running dual browser benchmark Add a new benchmark for measuring memory during prolonged usage of alternating browsers. Benchmark is same as memory.dual_browser_test, but the test is run for 60 iterations and the browser is *not* restarted between page set repeats. BUG=623015 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq ========== to ========== [tools/perf] Add long running dual browser benchmark Add a new benchmark for measuring memory during prolonged usage of alternating browsers. Benchmark is same as memory.dual_browser_test, but the test is run for 60 iterations and the browser is *not* restarted between page set repeats. BUG=623015 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Add long running dual browser benchmark Add a new benchmark for measuring memory during prolonged usage of alternating browsers. Benchmark is same as memory.dual_browser_test, but the test is run for 60 iterations and the browser is *not* restarted between page set repeats. BUG=623015 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq ========== to ========== [tools/perf] Add long running dual browser benchmark Add a new benchmark for measuring memory during prolonged usage of alternating browsers. Benchmark is same as memory.dual_browser_test, but the test is run for 60 iterations and the browser is *not* restarted between page set repeats. BUG=623015 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq Committed: https://crrev.com/968d1c528ba5eb455244132fd2efbb5fa5c7fa27 Cr-Commit-Position: refs/heads/master@{#402215} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/968d1c528ba5eb455244132fd2efbb5fa5c7fa27 Cr-Commit-Position: refs/heads/master@{#402215} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
