Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: content/browser/frame_host/navigation_controller_impl_browsertest.cc

Issue 2095833004: Disable test for rare in-page navigation kill in new navigation logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@workaround-for-subframe-restore-test
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/buildbot/filters/isolate-extensions.content_browsertests.filter » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl_browsertest.cc
diff --git a/content/browser/frame_host/navigation_controller_impl_browsertest.cc b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
index 5e7aeb68c53a3c74b713d8b1651556e77801ea51..040086f8a6c01ac982c3ec89412007baf60e9406 100644
--- a/content/browser/frame_host/navigation_controller_impl_browsertest.cc
+++ b/content/browser/frame_host/navigation_controller_impl_browsertest.cc
@@ -4190,8 +4190,12 @@ IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
// Test for in-page navigation kills due to using the wrong history item in
// HistoryController::RecursiveGoToEntry and NavigationControllerImpl::
// FindFramesToNavigate. See https://crbug.com/612713.
+//
+// TODO(creis): Enable this test when https://crbug.com/618100 is fixed.
+// Disabled for now while we switch to the new navigation path, since this kill
+// is exceptionally rare in practice.
IN_PROC_BROWSER_TEST_F(NavigationControllerBrowserTest,
- BackTwiceToIframeWithContent) {
+ DISABLED_BackTwiceToIframeWithContent) {
GURL links_url(embedded_test_server()->GetURL(
"/navigation_controller/page_with_links.html"));
NavigateToURL(shell(), links_url);
« no previous file with comments | « no previous file | testing/buildbot/filters/isolate-extensions.content_browsertests.filter » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698