Change loop bounds to be correct (and much less confusing)

Change loop bounds to be correct (and much less confusing)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095693002

Committed: https://skia.googlesource.com/skia/+/42a41499de94ff9201ca3c56554d7b92ce32b247

[Brian Osman, 2016-06-23 16:30:14]

Description was changed from

==========
Change loop bounds to be correct (and much less confusing)

BUG=skia:
==========

to

==========
Change loop bounds to be correct (and much less confusing)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095693002
==========

[Brian Osman, 2016-06-23 16:32:44]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[Brian Osman, 2016-06-23 16:32:44]

Found this while trying to understand what this GM does.

[reed1, 2016-06-23 17:43:30]

lgtm w/ or w/o my suggestion

https://codereview.chromium.org/2095693002/diff/1/gm/recordopts.cpp
File gm/recordopts.cpp (right):

https://codereview.chromium.org/2095693002/diff/1/gm/recordopts.cpp#newcode193
gm/recordopts.cpp:193: for (size_t j = 0; j <
SK_ARRAY_COUNT(detectorInstallFuncs); ++j) {
can we use the fancy style (and be perhaps even clearer)?

e.g.
for (auto shapeColor : shapeColors) {
   for (auto installFunc : detectorInstallFuncs) {
      ...

[Brian Osman, 2016-06-23 17:44:05]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-06-23 17:44:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2095693002/1

[commit-bot: I haz the power, 2016-06-23 17:59:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 17:59:47]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[Brian Osman, 2016-06-23 18:25:52]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-06-23 18:26:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2095693002/1

[commit-bot: I haz the power, 2016-06-23 18:40:17]

Description was changed from

==========
Change loop bounds to be correct (and much less confusing)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095693002
==========

to

==========
Change loop bounds to be correct (and much less confusing)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2095693002

Committed:
https://skia.googlesource.com/skia/+/42a41499de94ff9201ca3c56554d7b92ce32b247
==========

[commit-bot: I haz the power, 2016-06-23 18:40:18]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/42a41499de94ff9201ca3c56554d7b92ce32b247